Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chandan Chaudhary created an issue. See original summary.

Chandan Chaudhary’s picture

Chandan Chaudhary’s picture

Ignore patch 'devel_generate_2755781_missing_bundle_for_entity_type_2.patch' it has missing leading space.

Please find the update patch as 'devel_generate_2755781_missing_bundle_for_entity_type_3.patch'

Chandan Chaudhary’s picture

Status: Needs work » Needs review

The last submitted patch, 2: devel_generate_2755781_missing_bundle_for_entity_type_2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: devel_generate_2755781_missing_bundle_for_entity_type_3.patch, failed testing.

Chandan Chaudhary’s picture

Status: Needs work » Needs review
FileSize
878 bytes
lussoluca’s picture

Status: Needs review » Needs work
+++ b/devel_generate/src/Form/DevelGenerateForm.php
@@ -106,5 +106,16 @@ class DevelGenerateForm extends FormBase {
+              $form_state->setError($form['node_types'],$this->t('Please select atleast one content type'));

Just a small typo, then it's RTBC for me

willzyx’s picture

@Chandan Chaudhary thanks for the patch!
IMHO the approatch used in the patch is wrong. The form validation is pugin specific (ContentDevelGenerate) and should not resides in DevelGenerateForm, it should be located in the related plugin. Also we need test for this

willzyx’s picture

Status: Needs work » Needs review
Issue tags: +Needs tests
FileSize
3.1 KB

Somethig like this (not tested :p) could be a good start

itamair’s picture

Title: A fatal error occurred: Missing bundle for entity type node » A fatal error occurred: Missing bundle for entity type node xxx
itamair’s picture

Title: A fatal error occurred: Missing bundle for entity type node xxx » A fatal error occurred: Missing bundle for entity type node
Chandan Chaudhary’s picture

i have update the patch #10 and added the test cases for this issue.

willzyx’s picture

Changed a little the test.. otherwise looks good

  • willzyx committed 95479b3 on 8.x-1.x
    Issue #2755781 by Chandan Chaudhary, willzyx: A fatal error occurred:...
willzyx’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.