Problem/Motivation

The Roles page is the only place where it says "Save order" instead of simply "Save". In all other cases where a save button is applied to list of items that can be re-ordered, the button is just "Save" (sometimes with a second button to "Reset to alphabetically"

Changing the wording would improve usability by making the page consistent with other admin pages.

Proposed resolution

Change the wording of the button to "Save".

Remaining tasks

Check whether the wording also needs to be changed in tests and/or the hook_help text.

User interface changes

This is a UI interface text change and therefore might need changes in the hook_help text as well.

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

ifrik’s picture

chishah92’s picture

Assigned: Unassigned » chishah92
chishah92’s picture

Status: Active » Needs review
FileSize
1.27 KB

Have changed to "Save" at appropriate places.

Thanks!
~Chirag

urvigala’s picture

Assigned: chishah92 » Unassigned
Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

  • xjm committed 604887f on 8.2.x
    Issue #2753055 by chishah92, ifrik: Change "Save order" to "Save"
    
xjm’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.2.0

Looks good, thanks! I confirmed this cleans up all instances of that button text:

[mandelbrot:maintainer | Fri 16:46:28] $ grep -ri "save order" *
[mandelbrot:maintainer | Fri 16:46:34] $ 

Committed 604887f and pushed to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.