CommentFileSizeAuthor
#2 2752533-2.patch632 bytesmikeker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeker created an issue. See original summary.

mikeker’s picture

Status: Active » Needs review
FileSize
632 bytes
Anul’s picture

Status: Needs review » Reviewed & tested by the community

Applied this patch #2 and tested. It looks fine.

  • xjm committed faef09e on 8.2.x
    Issue #2752533 by mikeker: \Drupal\Component\Utility\Crypt::...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the patch! I grepped core to confirm this documentation error is the only instance of the string byte_count:

[mandelbrot:drupal | Tue 09:12:31] $ grep -r "byte_count" *
core/lib/Drupal/Component/Utility/Crypt.php:   *   The base64 encoded result will have a length of up to 4 * $byte_count

The parameter itself is correctly documented as $count. If it were a mismatch between the parameter docs themselves and the function declaration, we could check that programmatically across core, but for the parameter being mentioned inline in documentation, that does not apply.

Committed faef09e and pushed to 8.2.x. Thanks!

  • xjm committed 984e284 on 8.1.x
    Issue #2752533 by mikeker: \Drupal\Component\Utility\Crypt::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.