When a file is removed in AMP Metadata, it appears that the file is removed sitewide, regardless if it is in use elsewhere.

Make sure to only remove the file from the system if it no longer in use.

CommentFileSizeAuthor
#3 2752419-3-file-usage-check.patch534 bytesRainbowArray
#2 2752419-1-check-file-usage.patch1.05 KBRainbowArray
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mdrummond created an issue. See original summary.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented
Status: Active » Needs review
FileSize
2752419-1-check-file-usage.patch1.05 KB

This checks the usage of the organizational logo file before deleting. Pretty tricky to test this, as it would be a pretty rare thing to happen.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented
FileSize
2752419-3-file-usage-check.patch534 bytes

Here's the D7 version of the patch.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented

Probably overkill, but I tested the D8 version by doing this:

  • Add a file
  • Check that the file was uploaded
  • Remove the file
  • Make sure file was remove
  • Add another file
  • Make sure new file is there

All good. Committed to 8.x-1.x.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs review » Fixed

Did the same with D7. Committed to 7.x-1.x. Thanks, Marc.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.