API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...

Compare it with https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21.... The first page contains incorrect markup: The closing </h3> seems to miss the parenthesis, and it is rendered as <h3>Plugin annotationh3>; the next line shows the @code directive.

This is how the page in object appears.

Incorrect markup

This is how the other page appears.

correct markup

CommentFileSizeAuthor
#3 status-messages-doc.patch441 byteststoeckler
PageTitle___PageTitle_php___Drupal_8_2_x___Drupal_API.png6.47 KBapaderno
StatusMessages___StatusMessages_php___Drupal_8_2_x___Drupal_API.png19.29 KBapaderno
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue summary: View changes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Active » Needs review
FileSize
status-messages-doc.patch441 bytes

The problem is the @code in the in-code docs is not closed properly.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Documentation page contains incorrect markup » class StatusMessages documentation page contains incorrect markup

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: status-messages-doc.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

The testbot can't decide whether sequences exists or not:

fail: [Other] Line 210 of core/tests/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php:
Drupal\KernelTests\Core\Entity\EntityDefinitionUpdateTest::testBundleFieldCreateUpdateDeleteWithoutData
Drupal\Core\Database\SchemaObjectExistsException: Table sequences already exists.

/var/www/html/core/lib/Drupal/Core/Database/Schema.php:592
/var/www/html/core/tests/Drupal/KernelTests/KernelTestBase.php:818
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php:49
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php:46

fail: [Other] Line 83 of core/tests/Drupal/KernelTests/Core/Entity/EntityValidationTest.php:
Drupal\KernelTests\Core\Entity\EntityValidationTest::testValidation
Drupal\Core\Entity\EntityStorageException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'jenkins_default_153739.simpletest352706sequences' doesn't exist: INSERT INTO {sequences} () VALUES (); Array
(
)

/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:756
/var/www/html/core/lib/Drupal/Core/Entity/Entity.php:358
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php:113
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityValidationTest.php:61
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityValidationTest.php:117
/var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityValidationTest.php:106

In any case, sending for a re-test.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs work » Needs review
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented
Status: Needs review » Reviewed & tested by the community

#3 fixes the issue. I see the tests are also green ;-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 013d35c and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 90b986b on 8.2.x 
    Issue #2751121 by tstoeckler, kiamlaluno: class StatusMessages...

  • alexpott committed 013d35c on 8.1.x 
    Issue #2751121 by tstoeckler, kiamlaluno: class StatusMessages...
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.