At DynamicPageCacheSubscriber.php, there is a long phrase wrapped in parenthesis which does not need them, plus a missing parameter name.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juampynr created an issue. See original summary.

juampynr’s picture

Status: Active » Needs review
FileSize
1.88 KB

Here is a patch that fixes these.

mahtoranjeet’s picture

Assigned: Unassigned » mahtoranjeet
Status: Needs review » Reviewed & tested by the community

Reviewed the code and tested it.
Now Parenthesis is removed that was wrapping long phase and
Added the missing parameter

Wim Leers’s picture

Component: cache system » dynamic_page_cache.module
Assigned: mahtoranjeet » Unassigned
Priority: Normal » Minor
Issue tags: +Documentation

Thanks!

(Also: great to know that you actually read the documentation, @juampynr — hope you liked it :))

Wim Leers’s picture

Title: Fix typos at DynamicPageCacheSubscriber.php » Fix typos in documentation of \Drupal\dynamic_page_cache\EventSubscriber\DynamicPageCacheSubscriber
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7e2925c and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed fa14dcd on 8.2.x
    Issue #2744379 by juampynr: Fix typos in documentation of \Drupal\...

  • alexpott committed 7e2925c on 8.1.x
    Issue #2744379 by juampynr: Fix typos in documentation of \Drupal\...
juampynr’s picture

It has been the definitive way for me to understand how this works. Thanks.

Wim Leers’s picture

#9: yay :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.