See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

CommentFileSizeAuthor
#3 2742497-3.patch1.39 KBnaveenvalecha
#2 browsertest-ban-2742497-2.patch24.07 KBklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Active » Needs review
FileSize
browsertest-ban-2742497-2.patch24.07 KB

Includes the patch from #2735045: Convert StandardTest to BrowserTestBase by introducing a AssertLegacyTrait and new assertions on the WebAssert, please review that first.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
FileSize
2742497-3.patch1.39 KB

Reroll this after #2735045: Convert StandardTest to BrowserTestBase by introducing a AssertLegacyTrait and new assertions on the WebAssert

Status: Needs review » Needs work

The last submitted patch, 3: 2742497-3.patch, failed testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs work » Reviewed & tested by the community

Looks good, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Version: 8.2.x-dev » 8.1.x-dev

Committed 040c4db and pushed to 8.2.x. Thanks!

I'll cherry-pick to 8.1.x if tests pass there too.

  • alexpott committed eac234e on 8.2.x 
    Issue #2742497 by klausi, naveenvalecha: Convert web tests to browser...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

  • alexpott committed 4baccae on 8.1.x 
    Issue #2742497 by klausi, naveenvalecha: Convert web tests to browser...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.