API page: https://api.drupal.org/api/drupal/core!modules!ckeditor!ckeditor.module/...
The instructions for adding CkEditor stylesheets are based on the old system of .info files and should be updated to reflect .info.yml files. The correct documentation for this can be found at https://api.drupal.org/api/drupal/core!modules!ckeditor!ckeditor.api.php...
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff.txt | 463 bytes | star-szr |
#13 | instructions-2738891-13.patch | 848 bytes | martin107 |
#6 | instructions-2738891-6.patch | 882 bytes | rashid_786 |
Comments
Comment #2
remydenton CreditAttribution: remydenton at Isovera commentedComment #3
jhodgdonGood catch, and thanks for filing the issue! Seems like a good Novice project to update the docs here.
Comment #4
mayurjadhav CreditAttribution: mayurjadhav commentedComment #5
mparker17Unassigning because there has been no progress on this issue in more than two weeks, and it looks like a good candidate for the Drupal North 2016 coding sprint tomorrow.
@mayurjadhav, if you are still working on this, please assign it to yourself again!
Comment #6
rashid_786 CreditAttribution: rashid_786 at SDG Corporation commentedlatest changes applied.
Comment #7
martin107 CreditAttribution: martin107 commentedYep the docs should be updated. The patch looks good.
Comment #8
mayurjadhav CreditAttribution: mayurjadhav commentedPatch looks perfect, +1 for RTBC
Comment #10
martin107 CreditAttribution: martin107 commentedThis is a documentation only patch, and so this is a random test failure.
I am triggering a retest
Comment #11
Wim LeersIf it touches CKEditor, then please put it in that component, so I can review it as the module maintainer.
Comment #12
Wim LeersViolates 80 cols rule.
Proposed message:
Comment #13
martin107 CreditAttribution: martin107 commentedfixed.
Comment #14
Wim LeersThanks!
Comment #17
star-szrCommitted and pushed 4e9ed76 to 8.2.x and 619cbc3 to 8.1.x. Thanks!
The CSS line needs to be indented by one more space. Fixed on commit - see interdiff.
Comment #18
Wim LeersThanks, @Cottser :)