API page: https://api.drupal.org/api/drupal/core!modules!ckeditor!ckeditor.module/...

The instructions for adding CkEditor stylesheets are based on the old system of .info files and should be updated to reflect .info.yml files. The correct documentation for this can be found at https://api.drupal.org/api/drupal/core!modules!ckeditor!ckeditor.api.php...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

remydenton created an issue. See original summary.

remydenton’s picture

Issue summary: View changes
jhodgdon’s picture

Issue tags: +Novice

Good catch, and thanks for filing the issue! Seems like a good Novice project to update the docs here.

mayurjadhav’s picture

Assigned: Unassigned » mayurjadhav
mparker17’s picture

Assigned: mayurjadhav » Unassigned

Unassigning because there has been no progress on this issue in more than two weeks, and it looks like a good candidate for the Drupal North 2016 coding sprint tomorrow.

@mayurjadhav, if you are still working on this, please assign it to yourself again!

rashid_786’s picture

Status: Active » Needs review
FileSize
882 bytes

latest changes applied.

martin107’s picture

Status: Needs review » Reviewed & tested by the community

Yep the docs should be updated. The patch looks good.

mayurjadhav’s picture

Patch looks perfect, +1 for RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: instructions-2738891-6.patch, failed testing.

martin107’s picture

Status: Needs work » Reviewed & tested by the community
Related issues: +#2754217: Random Test Failure with "failed to open stream" for temporary://.htaccess

This is a documentation only patch, and so this is a random test failure.

I am triggering a retest

Wim Leers’s picture

Component: documentation » ckeditor.module
Issue tags: +Documentation

If it touches CKEditor, then please put it in that component, so I can review it as the module maintainer.

Wim Leers’s picture

Title: Instructions for adding CkEditor stylesheet are outdated » Instructions for adding CKEditor stylesheets are outdated
Version: 8.2.x-dev » 8.1.x-dev
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/ckeditor/ckeditor.module
@@ -68,13 +68,15 @@ function ckeditor_ckeditor_css_alter(array &$css, Editor $editor) {
- * Retrieves the default theme's CKEditor stylesheets defined in the .info file.
+ * Retrieves the default theme's CKEditor stylesheets defined in the .info.yml
+ * file.

Violates 80 cols rule.

Proposed message:

Retrieves the default theme's CKEditor stylesheets.
martin107’s picture

Status: Needs work » Needs review
FileSize
848 bytes

fixed.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • Cottser committed 4e9ed76 on 8.2.x
    Issue #2738891 by martin107, rashid_786, Wim Leers, remydenton:...

  • Cottser committed 619cbc3 on 8.1.x
    Issue #2738891 by martin107, rashid_786, Wim Leers, remydenton:...
star-szr’s picture

Status: Reviewed & tested by the community » Fixed
FileSize
463 bytes

Committed and pushed 4e9ed76 to 8.2.x and 619cbc3 to 8.1.x. Thanks!

+++ b/core/modules/ckeditor/ckeditor.module
@@ -68,13 +68,14 @@ function ckeditor_ckeditor_css_alter(array &$css, Editor $editor) {
+ * ckeditor_stylesheets:
+ *  - css/ckeditor-iframe.css

The CSS line needs to be indented by one more space. Fixed on commit - see interdiff.

Wim Leers’s picture

Thanks, @Cottser :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.