Hello. I found useless code: we don't need hook_uninstall for deleting configuration settings because config system should remove owned data itself. Please review my patch.

Thanks.

CommentFileSizeAuthor
#2 addanother_drupal_8_cleanup-2735721-1.patch420 bytesmkdok
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkdok created an issue. See original summary.

mkdok’s picture

mkdok CreditAttribution: mkdok commented
FileSize
addanother_drupal_8_cleanup-2735721-1.patch420 bytes
Robin Monks’s picture

Robin Monks CreditAttribution: Robin Monks commented
Status: Needs review » Fixed

Good catch, thanks!

  • mkdok authored 526d23f on 8.x-1.x 
    Issue #2735721 by mkdok: Drupal 8 code cleanup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.