It's my understanding that Admin Toolbar Tools simply adds additional tools / menu items / links. However, existing menu items do not fully swing out on hovering over the toolbar if is disabled.

Existing menu items should be fully accessible without having to enable the submodule.

The goal here is to provide the full swing-out menu functionality for clients using the toolbar, but not provide them with the Drupal-specific links that ship with Tools.

Please see the attached screenshots, one with the submodule disabled, and one with the submodule enabled. You'll note that it's not possible to drill down as far given that it's not possible to navigate to all of the items. Also, Content won't provide any menu items at all if Tools is missing.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colan created an issue. See original summary.

Balu Ertl’s picture

Hi @colan,

As far as I know the "Admin Toolbar Extra Tools" sub-module is only responsible for adding a single top-level menu item placed to the very left end of the tray, symbolized with a lightblue D8 logo. This "Admin Toolbar Extra Tools" sub-module has nothing to do with any other menu items and their descendant drop-downs. Based on the screenshots you attached I'm wondering whether does it relates to the fact of the sub-module is enabled or not.

@others: please correct me if I'm wrong.

colan’s picture

Nothing else on my system had changed between screenshots; I was simply running drush en admin_toolbar_tools and drush pmu admin_toolbar_tools (switching back and forth). Thanks for confirming my assumption and this bug.

romainj’s picture

Status: Active » Closed (works as designed)

Admin Toolbar Extra Tools provides additional menu items that are not generated by Drupal core. For example there are no items for each content type by default. That's the purpose of Admin Toolbar Extra Tools to add them. Same apply to the menu items related to menus.
I think that there is no bug so this issue should be closed.
Thanks anyway for your feedback.

colan’s picture

Version: 8.x-1.15 » 8.x-1.x-dev
Component: User interface » Documentation
Category: Bug report » Task
Status: Closed (works as designed) » Active

This should be documented on the main project page, the submodule's description and its README (if there is one). Currently, there's no evidence of this anywhere outside of the code.

As #2 suggests, folks believe Tools only provides the extra Drupal-specific menu. Let's enlighten them.

  • romainj committed cd6a2e5 on 8.x-1.x
    Issue #2735257 by Balu Ertl, colan, romainj: added some description...
romainj’s picture

Status: Active » Fixed

I added a README.txt file to the Admin Toolbar Extra Tools module.

colan’s picture

Status: Fixed » Needs work

Thanks! That's a good start, but it still needs to say that it adds things discussed in #4.

  • romainj committed 081c07e on 8.x-1.x
    Issue #2735257 by Balu Ertl, colan, romainj: improves Admin Toolbar...
romainj’s picture

Status: Needs work » Needs review

I completed the description of the README.txt file in the latest dev version.

colan’s picture

Status: Needs review » Needs work

Looks great, except that the line is now really long. We should keep lines <= 80 characters in READMEs.

Thanks for adding the text.

  • romainj committed dbc8c74 on 8.x-1.x
    Issue #2735257 by colan, romainj, Balu Ertl: shortens the module README....
romainj’s picture

Status: Needs work » Fixed

Edit done in latest dev version.

colan’s picture

Status: Fixed » Needs work

Sorry, I suppose I wasn't clear earlier, and I apologize. The longer text you had was perfect, but it was in a very long line. All of the text should remain, but the line should be wrapped to make the text multiple lines so that each line doesn't go over 80 characters. So we should have something like this:

Admin Toolbar Extra Tools provides menu links to administration pages or 
actions (eg. Flushing caches). It adds menu items that are not generated by 
Drupal core. For example there are no menu items for each content type by 
default or menu links to Manage fields on each entity types. That's the purpose
of Admin Toolbar Extra Tools to add them.

This is easily done in Vim with the command gq}.

  • romainj committed 041de30 on 8.x-1.x
    Issue #2735257 by colan, romainj, Balu Ertl: respect of coding standards...
romainj’s picture

Status: Needs work » Fixed

Fixed :)

colan’s picture

Perfect. Merci beaucoup!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.