SafeMarkup::checkPlain is going to depreciate.

Will be removed before Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use the #plain_text key when constructing a render array that contains plain text in order to use the renderer's auto-escaping feature. If neither of these are possible, \Drupal\Component\Utility\Html::escape() can be used in places where explicit escaping is needed.

CommentFileSizeAuthor
#12 remove_deprecated-2734983-12.patch3.3 KBdimaro
#10 drupal-2734983.patch3.28 KBNikhilesh Gupta
#8 drupal8-2734983.patch4.68 KBNikhilesh Gupta
#6 drupal-2734983-6.patch3.5 KBmayurjadhav
#3 drupal-2734983.patch5.09 KBneerajsingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neerajsingh created an issue. See original summary.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Assigned: Unassigned » neerajsingh
Status: Active » Needs work
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Assigned: neerajsingh » Unassigned
Status: Needs work » Needs review
FileSize
drupal-2734983.patch5.09 KB

Patched.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work 
+++ b/core/tests/Drupal/Tests/Component/Utility/SafeMarkupTest.php
@@ -58,20 +53,20 @@ public function testIsSafe() {
-    $result = SafeMarkup::checkPlain($text);
+    $result = Html::escape($text);

This is the SafeMarkup test, we don't want to change it here since we need to test the method (even if it is deprecated).

The last submitted patch, 3: drupal-2734983.patch, failed testing.

mayurjadhav’s picture

mayurjadhav CreditAttribution: mayurjadhav commented
Status: Needs work » Needs review
FileSize
drupal-2734983-6.patch3.5 KB

Reverted deprecated SafeMarkup changes from Test.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: Remove deprecated SafeMarkup::checkPlain from core » Remove deprecated SafeMarkup::checkPlain usages from core
Nikhilesh Gupta’s picture

Nikhilesh Gupta CreditAttribution: Nikhilesh Gupta as a volunteer and at Melity commented
FileSize
drupal8-2734983.patch4.68 KB

Attached patch removes all SafeMarkup::checkPlain deprecated usages from core.

Status: Needs review » Needs work

The last submitted patch, 8: drupal8-2734983.patch, failed testing.

Nikhilesh Gupta’s picture

Nikhilesh Gupta CreditAttribution: Nikhilesh Gupta as a volunteer and at Melity commented
Status: Needs work » Needs review
FileSize
drupal-2734983.patch3.28 KB

Status: Needs review » Needs work

The last submitted patch, 10: drupal-2734983.patch, failed testing.

dimaro’s picture

dimaro CreditAttribution: dimaro at La Drupalera by Emergya commented
Status: Needs work » Needs review
FileSize
remove_deprecated-2734983-12.patch3.3 KB

Rerolled #10.
Simple rebase fixed it.

dimaro’s picture

dimaro CreditAttribution: dimaro at La Drupalera by Emergya commented

I checked all the usages of SafeMarkup::checkPlain. All were removed except those in class SafeMarkupTest.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lucur’s picture

lucur CreditAttribution: lucur at Reinblau commented

Patch works for 8.3.x-dev

lucur’s picture

lucur CreditAttribution: lucur at Reinblau commented
Status: Needs review » Reviewed & tested by the community

  • catch committed fc4f5cc on 8.3.x 
    Issue #2734983 by Nikhilesh Gupta, neerajsingh, dimaro, mayurjadhav:...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.