Problem/Motivation

The day has come

Proposed resolution

Remaining tasks

Convert the DrupalKernelTest over
Remove the MissingDependencies one, as it doesn't make sense in the phpunit case? (not sure about that to be honest)

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 convert_the_remaining-2734423-7.patch6.85 KBjibran
#2 2734423-2.patch7.44 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2734423-2.patch7.44 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Title: Convert the remaining old kernelt tests over » Convert the remaining old kernel tests over

Status: Needs review » Needs work

The last submitted patch, 2: 2734423-2.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Duplicate of #2734663: Update deprecation message for old KernelTestBase in simpletest

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs work » Closed (duplicate)

@jibran
Good find, thank you!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Closed (duplicate) » Needs review
FileSize
convert_the_remaining-2734423-7.patch6.85 KB

Let's convert the tests here and removal discussion can go on in #2734663: Update deprecation message for old KernelTestBase in simpletest.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Parent issue: » #2304461: KernelTestBaseTNG™
Related issues: +#2734663: Update deprecation message for old KernelTestBase in simpletest
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

@jibran
Good idea! This looks perfect for me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 3a7b1e0 and pushed to 8.1.x and 8.2.x. Thanks!

I've committed to 8.1.x as well because afaics this doesn't remove anything and it helps keep all the tests in sync.

  • alexpott committed 587c514 on 8.2.x 
    Issue #2734423 by dawehner, jibran: Convert the remaining old kernel...

  • alexpott committed 3a7b1e0 on 8.1.x 
    Issue #2734423 by dawehner, jibran: Convert the remaining old kernel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.