Problem/Motivation

Sometimes (specially when content comes from other sources) it would be useful to convert plain URLs to tags that can be later picked up by the default filter and converted to embeds.

Proposed resolution

Add a filter that does that.

CommentFileSizeAuthor
#5 interdiff.txt1.29 KBslashrsm
#5 2733385_5.patch13.1 KBslashrsm
#3 interdiff.txt8.64 KBslashrsm
#3 2733385_3.patch13.12 KBslashrsm
#2 2733385_1.patch7.22 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Active » Needs review
FileSize
2733385_1.patch7.22 KB
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
FileSize
2733385_3.patch13.12 KB
interdiff.txt8.64 KB

Added optional prefix that triggers conversions.

PR for tests: https://github.com/drupal-media/url_embed/pull/32

thenchev’s picture

thenchev CreditAttribution: thenchev at MD Systems GmbH for Acquia commented
Status: Needs review » Needs work 
+++ b/src/Tests/ConvertUrlToEmbedFilterTest.php
@@ -0,0 +1,134 @@
+use Drupal\video_embed_field\Tests\WebTestBase;

Wrong use statement.

+++ b/src/Plugin/Filter/ConvertUrlToEmbedFilter.php
@@ -0,0 +1,191 @@
+      '#title' => $this->t('URL prefox'),

typo

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
2733385_5.patch13.1 KB
interdiff.txt1.29 KB
thenchev’s picture

thenchev CreditAttribution: thenchev at MD Systems GmbH for Acquia commented
Status: Needs review » Reviewed & tested by the community

Its passing on the pull request. Looks good to go.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • slashrsm committed 6554740 on 8.x-1.x 
    Issue #2733385 by slashrsm, Denchev: Add a text filter that converts...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.