Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Darn and Double Drat, there are just not enough 'd's in the code base
Let us add some more, new stuff will show up in the documentation!
Comment | File | Size | Author |
---|---|---|---|
#8 | darn-2729083-8.patch | 3.5 KB | martin107 |
Comments
Comment #2
martin107 CreditAttribution: martin107 commentedComment #3
jhodgdonThanks!
Comment #4
jhodgdonI wonder if we should add a Coder sniff for @tags that we don't recognize? The list of recognized tags can be found on https://www.drupal.org/node/1354.
Comment #5
martin107 CreditAttribution: martin107 commented@returns, @throw ... all subtly wrong. it is easy to do.
whitelisting @tags would keep us honest :)
Comment #6
jhodgdonFiled #2729697: Add a sniff for unknown docs @ tags to deal with the sniffer.
Comment #7
xjmLooks good; I think it makes sense to fix all the "@encode" in one patch and it looks like this does.
The patch does not currently apply though. (I have no idea why it never got picked up by the testbots.)
Comment #8
martin107 CreditAttribution: martin107 commentedInstead of reroll - I just redid the work - it seems easier with small patches.
The issue summary change is just " becomes '
As for the patch not getting picked up ... Bedir recently told me he has observed things sometimes go bad regarding testbot's uploading of files. Specifically when the patch is submitted at the point of creation. ( ie. for patches associated with comment #1 - not the Big Bang - oh language fails me again! )
Comment #9
jhodgdonThanks again!
Comment #12
xjmLOL.
Committed to 8.2.x and 8.1.x. Thanks!