Darn and Double Drat, there are just not enough 'd's in the code base

Let us add some more, new stuff will show up in the documentation!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

Issue tags: +Quickfix
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

jhodgdon’s picture

I wonder if we should add a Coder sniff for @tags that we don't recognize? The list of recognized tags can be found on https://www.drupal.org/node/1354.

martin107’s picture

@returns, @throw ... all subtly wrong. it is easy to do.

whitelisting @tags would keep us honest :)

jhodgdon’s picture

Filed #2729697: Add a sniff for unknown docs @ tags to deal with the sniffer.

xjm’s picture

Status: Reviewed & tested by the community » Needs work

Looks good; I think it makes sense to fix all the "@encode" in one patch and it looks like this does.

The patch does not currently apply though. (I have no idea why it never got picked up by the testbots.)

martin107’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
3.5 KB

Instead of reroll - I just redid the work - it seems easier with small patches.

The issue summary change is just " becomes '

As for the patch not getting picked up ... Bedir recently told me he has observed things sometimes go bad regarding testbot's uploading of files. Specifically when the patch is submitted at the point of creation. ( ie. for patches associated with comment #1 - not the Big Bang - oh language fails me again! )

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks again!

  • xjm committed 1694030 on 8.1.x
    Issue #2729083 by martin107, jhodgdon: @encode becomes @endcode
    

  • xjm committed fbe287d on 8.2.x
    Issue #2729083 by martin107, jhodgdon: @encode becomes @endcode
    
    (cherry...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

submitted at the point of creation. ( ie. for patches associated with comment #1 - not the Big Bang

LOL.

Committed to 8.2.x and 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.