Problem/Motivation

\Drupal\simpletest\ContentTypeCreationTrait::createContentType() rebuilds the router, but that is not (no longer?) necessary

Proposed resolution

Remove the router rebuild.

Remaining tasks

Review patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
test-create-content-type-router-rebuild.patch728 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

I cannot think of a good reason for that either

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Needless router rebuilds in the test infra might hide bugs so I've committed this to 8.1.x too. Committed 93d28a0 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 104134f on 8.2.x 
    Issue #2725441 by tstoeckler: \Drupal\simpletest\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.