INSTALL.txt tells me to

Navigate to Administration > Configuration > Media > File system

to change the file system path. But in Drupal 8 this must be changed in settings.php.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e.r.n.i.e created an issue. See original summary.

cilefen’s picture

Yes, it does need changing.

jhodgdon’s picture

Version: 8.1.1 » 8.1.x-dev
Issue tags: -d8docs, -INSTALL.txt, -file system path +Novice

Removing extraneous tags, and adding Novice tag. Also fixing version.

snehi’s picture

Status: Active » Needs review
FileSize
1.09 KB

Uploading first patch for this issue.

jhodgdon’s picture

Status: Needs review » Needs work

Thanks! This is a good start. A few thoughts:

  1. Just before the part affected by this patch, INSTALL.txt says something about "the files directory created in step 4". It is actually in step 3. Let's fix this in this patch too?
  2. I think we need to clarify in the new instructions that you can either enter a directory relative to the Drupal root, or else a full system directory starting with / ... although what about Windows? I have no idea...
  3. +++ b/core/INSTALL.txt
    @@ -226,11 +226,17 @@ INSTALLATION
    +   b. Open your settings.php in your favourite editor, and uncomment this line:
    

    We use American spellings in Drupal files, so "favorite". Actually though, let's not say "your favorite editor", but "a plain-text editor".

  4. Also... would someone who is not a coder know how to "uncomment" a line anyway? How about explicit instructions to remove the # at the start instead?
  5. +++ b/core/INSTALL.txt
    @@ -226,11 +226,17 @@ INSTALLATION
    +      you need to uncomment following line in settings.php and then enter the
    

    missing "the" before "following". Also see above about uncomment.

  6. I think the part about private files should be a new paragraph, not a "Note".
Sonal.Sangale’s picture

Assigned: Unassigned » Sonal.Sangale
Sonal.Sangale’s picture

Status: Needs work » Needs review
FileSize
1.6 KB
1.37 KB

Modifications are added as per the suggestions.

I think we need to clarify in the new instructions that you can either enter a directory relative to the Drupal root, or else a full system directory starting with / ... although what about Windows? I have no idea...

There are many ways to write the directory structure as per the documentation. Which way should be used in documentation?

jhodgdon’s picture

Status: Needs review » Needs work

Thanks, looking better!

  1. +++ b/core/INSTALL.txt
    @@ -226,11 +226,19 @@ INSTALLATION
    +   b. Open your settings.php in a plain-text editor, and uncomment(remove the #
    

    needs a space before (

  2. +++ b/core/INSTALL.txt
    @@ -226,11 +226,19 @@ INSTALLATION
    +      Enter the desired path.
    +      If you want to use private file storage, you need to uncomment(remove
    

    This is a paragraph break. Needs a blank line between the paragraphs. Also in the second line here, needs a space before the (

  3. +++ b/core/INSTALL.txt
    @@ -226,11 +226,19 @@ INSTALLATION
    +      and save the file.
    

    Can you make this into a complete sentence?

  4. Regarding the question of how to explain what a file path is and how to specify it, I guess I would just say something like "relative to your Drupal installation directory" and leave it at that.
snehi’s picture

Status: Needs work » Needs review
FileSize
1.59 KB
1.13 KB

Done.

jhodgdon’s picture

Status: Needs review » Needs work

Looks great! One small thing:

+++ b/core/INSTALL.txt
@@ -226,11 +226,19 @@ INSTALLATION
+      Enter the desired path.

Can we add 'and save the file' to this sentence too? Because as the patch is now, the only place it says to save the file is in the part about private files. So we should say it here too (either that or assume people would know to save the file and omit it in both places?) (probably saying "save the file" is fine though, but let's be consistent and do it in both places).

er.pushpinderrana’s picture

Status: Needs work » Needs review
FileSize
1.61 KB
459 bytes

Incorporated suggested changes.

snehi’s picture

Status: Needs review » Reviewed & tested by the community

Now i think all the suggestions and corrections given by @jhodgdon in #5 , #8 and #10 are incorporated.
So making this RTBC.

jhodgdon’s picture

Looks good to me too, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2724553-11.patch, failed testing.

ashishdalvi’s picture

Status: Needs work » Reviewed & tested by the community

Looks like. Patch failing is due to unrelated reason. https://www.drupal.org/node/2724871

Changing status to RTBC as per previous comment.

  • catch committed 4012b7e on 8.2.x
    Issue #2724553 by snehi, Sonal.Sangale, er.pushpinderrana, jhodgdon, e.r...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x, thanks!

  • catch committed aeec0d5 on 8.1.x
    Issue #2724553 by snehi, Sonal.Sangale, er.pushpinderrana, jhodgdon, e.r...
catch’s picture

And cherry-picked to 8.1.x...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.