Add support for unlimited value Address fields

Thanks for documenting this. We haven't really optimized for this use case, since it's hard to distinguish multiple addresses semantically (that's why we do some kind of entity above, that can tell us what the purpose of the address is). I'll make sure to address it in the upcoming months.

Same issue here. On update/creating nodes, the country is set and the node can't be saved/updated because of the required fields..

Hi All!
I ran into this too. The fix for having to to set the empty field to none when the node is edited is: to go into Manage Form Display then find your Address field and set the country to none. That way when a user edits the node they will not need to go and change the country to none to save.

Obviously this is still an issue. It can make sense to lock a user to a specific country and make at least one address required. Not being able to remove the empty additional address means the content can't be edited.

Hi there, I just want to share the work-around that I came up with, which I think will suffice our needs (pending user testing).

In our case, we needed at least one `proponent` address, and they were most likely going to be in Canada.

Step 1: I removed any required fields from the GUI and I removed any Country requirements as well.

Step 2: I added the following to mymodule_form_alter():

if ($node->hasField('field_proponent')) {
  // we need at least one proponent so make the first value required
  $form['field_proponent']['widget'][0]['address']['#required'] = TRUE;
  if ($node->isNew()) {
    // for new content, let's assume the first proponent will be in Canada 
    // will most likely be the case 99% of the time and users have the ability to change this value if they need
    $form['field_proponent']['widget'][0]['address']['#default_value']['country_code'] = 'CA';
  }
}

The above solution allows us to have a the first field required and set to a Canadian address for a better UX. Adding additional `proponents` is not as smooth an experience and we can't require them but this allows us to add and remove field values and allows us to save the form.

Retitling, reclassifying. This is not something we've ever supported (D7 or D8), but there's no reason not to.

Marked #3005487: Address field + unlimited values causes node/add form to have 5 address fieldsets as duplicate.

+1 for adding support for this. Our use case: database of health care practices, many of which have multiple office locations. Client wants to be able to search by practice characteristics (which we do NOT want to duplicate), and also to see where their offices are.

This happens because, when the field is set as required, all country fields are set as required. This patch checks the cardinality of the field and sets as required only the first one, this way it, when using a cardinality above 1, all additional instances are not required.

I did some refactoring to the test, so it is clearer.

I tested the patch functionally and it works fine. Good job.
However, it needs some improvement on readability and some minor things. I will give you more specific list of comments in PM.

I updated the patch to improve comments and make the code more readable.

Thank you @enriquelacoma. The patch looks good, tested locally and it works.

I've tested the patch from #13 and it works.

Patch#13 worked for me.

Good work on the test coverage!

Committed! Thanks @enriquelacoma!