Parent Issue

#2359437: [meta] Remove entity_load* family of functions usage from the code base

Problem/Motivation

There are case where entities of the entity_test family of entity types are retrieved using the functional loader, entity_load*()

The entity types to be changed are:

  • entity_test
  • entity_test_rev
  • entity_test_ml
  • entity_test_mulrev

These entity types are handled in one sub-issue, because they are tightly related, and are exposed by the same module

Proposed resolution

Replace calls to entity_load*('entity_test*', ...) with EntityTest*::load*() or by using \Drupal::entityTypeManager()->getStorage('entity_test*')->load*(...)

CommentFileSizeAuthor
#4 2723591-4.patch36.26 KBmarvin_B8
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

valthebald created an issue. See original summary.

valthebald’s picture

Title: Remove entity_load* usage for entity_test entity type » Remove entity_load* usage for entity_test, entity_test_rev, entity_test_ml entity types
Issue summary: View changes
valthebald’s picture

Title: Remove entity_load* usage for entity_test, entity_test_rev, entity_test_ml entity types » Remove entity_load* usage for entity_test, entity_test* entity types
Issue summary: View changes
marvin_B8’s picture

Status: Active » Needs review
FileSize
36.26 KB
John Cook’s picture

Status: Needs review » Reviewed & tested by the community

There are no more instances of entity_load*('entity_test*', ...) after applying the patch in #4.

The patch only addresses the problem with this issue.

John Cook’s picture

Issue summary: View changes

Updated summary.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 899cb52 and pushed to 8.2.x. Thanks!

  • catch committed 899cb52 on 8.2.x
    Issue #2723591 by marvin_B8: Remove entity_load* usage for entity_test,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.