Parent Issue

#2359437: [meta] Remove entity_load* family of functions usage from the code base

Problem/Motivation

There are case where entities of the view entity type are retrieved using the functional loader, entity_load()

Proposed resolution

Replace calls to entity_load('view', ...) with View::load()

CommentFileSizeAuthor
#6 drupal-remove_entity_load_usage_for_view-2723585-2.patch10.59 KBdanielmrichards
#3 drupal-remove_entity_load_usage_for_view-2723585-1.patch.patch10.61 KBdanielmrichards
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

valthebald created an issue. See original summary.

danielmrichards’s picture

danielmrichards CreditAttribution: danielmrichards as a volunteer commented

I'll take a look at this as part of the DrupalCon NOLA sprints

danielmrichards’s picture

danielmrichards CreditAttribution: danielmrichards as a volunteer commented
FileSize
drupal-remove_entity_load_usage_for_view-2723585-1.patch.patch10.61 KB
danielmrichards’s picture

danielmrichards CreditAttribution: danielmrichards as a volunteer commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: drupal-remove_entity_load_usage_for_view-2723585-1.patch.patch, failed testing.

danielmrichards’s picture

danielmrichards CreditAttribution: danielmrichards as a volunteer commented
FileSize
drupal-remove_entity_load_usage_for_view-2723585-2.patch10.59 KB

Fixing failing test

danielmrichards’s picture

danielmrichards CreditAttribution: danielmrichards as a volunteer commented
Status: Needs work » Needs review
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald as a volunteer commented
Status: Needs review » Reviewed & tested by the community

After applying the patch from #6, there are no more occurences of entity_load.*\('view'

John Cook’s picture

John Cook CreditAttribution: John Cook commented
Issue summary: View changes

Updated the summary to help submitters.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed ac4b5c7 and pushed to 8.2.x. Thanks!

  • alexpott committed ac4b5c7 on 8.2.x 
    Issue #2723585 by danielmrichards, valthebald, John Cook: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.