Problem/Motivation

API Documentation : https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Mail!MailManager....
The docs mention user_preferred_langcode() twice, but this function no longer exists in D8.

Proposed resolution

Update documentation with new method
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Session%2...

Remaining tasks

Update documentation

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#10 mailmanager_docs-2722265-10.patch1.74 KBkellyimagined
#10 interdiff.txt1.32 KBkellyimagined
#5 mailmanager_docs-2722265-4.patch1.29 KBwillito
#4 patch.diff1.29 KBwillito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

willito’s picture

willito CreditAttribution: willito commented

We're on it...whatever it is!

selfuntitled’s picture

selfuntitled CreditAttribution: selfuntitled commented
Issue summary: View changes

Put issue summary in template

willito’s picture

willito CreditAttribution: willito commented
FileSize
patch.diff1.29 KB

Here's a potential patch.

willito’s picture

willito CreditAttribution: willito commented
FileSize
mailmanager_docs-2722265-4.patch1.29 KB
munizjor’s picture

munizjor CreditAttribution: munizjor commented
Status: Active » Needs review
hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Mail/MailManagerInterface.php
@@ -23,7 +23,7 @@
-   * user_preferred_langcode(). If you send email based on form values filled on
+   * \Drupal\Core\Session\AccountInterface::getPreferredAdminLangcode(). If you send email based on form values filled on

Thank you for the patch!

As per Drupal coding standards, the comments cannot be longer than the 80 character marker. Please break up this line.

lisa.ugray’s picture

lisa.ugray CreditAttribution: lisa.ugray at University of Ottawa commented 
+++ b/core/lib/Drupal/Core/Mail/MailManagerInterface.php
@@ -23,7 +23,7 @@
+   * \Drupal\Core\Session\AccountInterface::getPreferredAdminLangcode(). If you send email based on form values filled on

You should wrap your documentation at 80 chars per line.

kellyimagined’s picture

kellyimagined CreditAttribution: kellyimagined commented

About to head to lunch, will fix line wrap after lunch.

kellyimagined’s picture

kellyimagined CreditAttribution: kellyimagined commented
FileSize
interdiff.txt1.32 KB
mailmanager_docs-2722265-10.patch1.74 KB

Fixed problem with line wrapping.

soulsesa’s picture

soulsesa CreditAttribution: soulsesa commented
Status: Needs work » Needs review
kellyimagined’s picture

kellyimagined CreditAttribution: kellyimagined commented
Issue tags: +neworleans2016
kurthill4’s picture

kurthill4 CreditAttribution: kurthill4 commented

Our group will review and (hopefully) RTBC now...

kjl16’s picture

kjl16 CreditAttribution: kjl16 commented

Yes I have looked at the interdiff and comments are wrapping at 80 characters.

The Sean’s picture

The Sean CreditAttribution: The Sean commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed deaf760 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 56e416c on 8.2.x 
    Issue #2722265 by willito, kellyimagined, joachim, hussainweb, munizjor...

  • alexpott committed deaf760 on 8.1.x 
    Issue #2722265 by willito, kellyimagined, joachim, hussainweb, munizjor...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.