Searching breaks when user enters a slash

Mmm yeah, there's probably not a (clean) way to get this working when clean urls is enabled, unless I add more parts to the path when generating the route.

Proof of concept attached, probably needs some serieus testing, cleanup and fine-tuning, but overall it seems to work and is not too hackish. Needs review for approach.

I don't have any experience with PathProcessors so can't comment on that specifically but the patch is working for me.

This looks good, but I have some nits to pick.

1. +++ b/search_api_page.services.yml
   @@ -0,0 +1,6 @@
   +        - { name: path_processor_inbound, priority: 300 }
   \ No newline at end of file
   

   Needs new blank line.

2. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +
   +class PathProcessorSearchApiPage implements \Drupal\Core\PathProcessor\InboundPathProcessorInterface {
   

   Needs a class docblock. I think we can also import the InboundPathProcessorInterface to make this line < 80 chars.

3. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +  public function __construct(EntityTypeManagerInterface $entityTypeManager, LanguageManagerInterface $languageManager, ConfigFactoryInterface $config) {
   

   I think these also need a docblock.

   /**
    * The class constructor
    *
    * @param...
   

4. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +  public function processInbound($path, Request $request) {
   

   Needs a docblock.

5. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +    return $path;
   

   This is what happens when nothing matches, right? Would it make sense to document that?

6. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +  protected function getSearchApiPagePathsUsingCleanUrls() {
   

   Let's give this a docblock as well.

   I also think we can refactor this method to be a little bit easier. But that's interpretation/taste. Can be left alone I think.

   
   $pages = array_filter($pages, function($i) {
     return $i->getCleanUrl();
   });
   
   // Pseudocode w/ changed flow.
   foreach ($pages as $page) {
   if (!$is_multilingual) {
     $paths[] = '/' . $page->getPath();
   }
   else {
     foreach(->getLanguages as $language) {
     $pathOverride = $this->...->get('path');
   
   $paths[] = $pathOverride ?: $path
   }
   }
   }
   
   

7. +++ b/src/PathProcessor/PathProcessorSearchApiPage.php
   @@ -0,0 +1,84 @@
   +}
   \ No newline at end of file
   

   Needs newline.

Do you think we should keep this as a seperate service or should we integrate this with #2794119: Wrong URL on language switcher block?

Fixed my own comments + added a test.

Rerolled.

This breaks the tests added in #2904203: Spaces in searchs cause AliasManager to throw errors., so we need to fix this to still pass with those tests added.

I fixed this, and now the previous tests also passes. This is the only significant change.

-        return $search_api_clean_url_path . urlencode($keys);
+        return $search_api_clean_url_path . rawurlencode($keys);

I made some other changes, such as indenting the yaml correctly, and I moved one getter out of the foreach, for some better performance. This is probably just a few ms, because otherwise this was coming from a static cache - but I guess even just a function call can make a small difference.

All we need is a +1, so we can get this in.

Committed this, we have a test that proves this works.