Problem/Motivation

According to core/composer.json the drupal/core package can be used to replace "drupal/core-file-cache" and "drupal/core-php-storage" but this is a lie because no such components exist.
We do have "drupal/core-fileCache" and "drupal/core-phpStorage"

Proposed resolution

Simply fix the replace section to stop the lie and to make drupal/core resolve any "drupal/core-fileCache" and "drupal/core-phpStorage" dependencies. Changing the component names at this point is a breaking change so let's leave that for another issue.

API changes

None.

CommentFileSizeAuthor
#10 2720811-10.patch935 bytesEric_A
#2 2720811-2.patch550 bytesEric_A
#3 2720811-3.patch809 bytesEric_A
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eric_A created an issue. See original summary.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Assigned: Eric_A » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
2720811-2.patch550 bytes
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Title: drupal/core replaces non-existant drupal/core-file-cache » drupal/core replaces non-existant drupal/core-*-* components
Issue summary: View changes
FileSize
2720811-3.patch809 bytes

One more mismatch: replace section has "drupal/core-php-storage" but we have "drupal/core-phpStorage".

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Related issues: +#2456009: Add a "replace" section to core/composer.json, +#2600730: Add composer.json to \Drupal\Component\FileCache component., +#2600736: Add composer.json to \Drupal\Component\PhpStorage component., +#2337283: Add a composer.json file to every component
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Parent issue: » #2720739: [meta] drupal/core-* components and drupal/core requires/replace declarations are broken

Given the names used, it's probably a better idea to rename the components than changing the replace section.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Title: drupal/core replaces non-existant drupal/core-*-* components » drupal/core replaces non-existent drupal/core-*-* components
Issue summary: View changes
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Title: drupal/core replaces non-existent drupal/core-*-* components » drupal/core-fileCache and drupal/core-phpStorage cannot be resolved by Composer (drupal/core replaces non-existent "drupal/core-file-cache" and "drupal/core-php-storage")
Issue summary: View changes

Renaming the components at this point would be a breaking change. Let's just fix a bug and do #3.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Issue summary: View changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Needs work

Patch in #3 applies and makes the package names match.

I'd say that we should fix the package names before they're made available in the stubtree split though. Now's the time.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Status: Needs work » Needs review
FileSize
2720811-10.patch935 bytes

Patch in #3 applies and makes the package names match.

I'd say that we should fix the package names before they're made available in the stubtree split though. Now's the time.

Here's the alternative to #3.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Title: drupal/core-fileCache and drupal/core-phpStorage cannot be resolved by Composer (drupal/core replaces non-existent "drupal/core-file-cache" and "drupal/core-php-storage") » Fix package names of drupal/core-fileCache and drupal/core-phpStorage
Status: Needs review » Reviewed & tested by the community

Thanks. RTBC for #10. Package names now match replace from core/composer.json, and also match other hyphenated component names like drupal/core-dependency-injection.

If we prefer camelCase package names, then the patch in #3 is good.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented

RTBC for #10, as inofficial FileCache subcomponent co-maintainer, I like file-cache much more than fileCache in the composer.json.

Not sure, but this might need a CR though.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2720811-10.patch, failed testing.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Random test failure

Back to RTBC, random test fail?

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

#10 still applies and does the same stuff. RTBC +1. Silly testbot!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

And these are the names already in core/composer.json replace section... nice.

Committed and pushed 30555f01388308b198dfed1903a34e63696a6e47 to 8.2.x and 1252b70 to 8.1.x. Thanks!

  • alexpott committed 1252b70 on 8.1.x 
    Issue #2720811 by Eric_A: Fix package names of drupal/core-fileCache and...

  • alexpott committed 30555f0 on 8.2.x 
    Issue #2720811 by Eric_A: Fix package names of drupal/core-fileCache and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.