Placeholders with exclamation mark (!placeholder) in t()-functions are no longer supported in Drupal 8: https://www.drupal.org/node/2575819
The name module uses these placeholders in various places, causing errors.
On top of that, the part of the code that checks whether all necessary components are filled in, contains an error:
$missing_components = array_diff($minimum_components, array_keys($item_components));
should be
$missing_components = array_diff(array_keys($minimum_components), array_keys($item_components));
Otherwise you get errors.
Patch included. I may have gone a bit overboard, but I replaced all !placeholders with @placeholders, I fixed the components validation error and I also changed the field-required error string to conform with the default field-required error strings.
Comment | File | Size | Author |
---|---|---|---|
#2 | name-validation-errors-fix-2715203-8.x.patch | 6.78 KB | gillesv |
|
Comments
Comment #2
gillesv CreditAttribution: gillesv commentedComment #3
MichelleI tested this and it works. Marking needs review so the test bot hits it.
Comment #4
MichelleThe bot likes it and it worked for me so marking RTBC. Would be good to get this in as it fixes a bunch of bugs.
Comment #5
rootworkPatch continues to apply...
Comment #7
Alan D. CreditAttribution: Alan D. commentedThanks everyone
Just really about to use the module for the first time on a D8 project, so a series of patches will get pushed though :)