Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2469713: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary
Problem/Motivation
ToolbarIntegrationTest
is not readable.
Proposed resolution
Perform the page level operation rather then working with css selectors.
Remaining tasks
Review
Commit
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#14 | modernized-2711963-14.patch | 4.83 KB | jibran |
Comments
Comment #2
jibranComment #3
jibranLet's remove the obsolete functions as well.
Comment #4
dawehnerTotally agree that this is much nicer. On the other hand I'm not sure whether its okay to remove those API functions now, it is sort of a unnecessary break. Do you mind keeping them and add a @deprecated with an explanation what one should do instead?
Comment #5
dawehnerThe changes itself look awesome!
Comment #6
jibranAs per my understanding JTB is in experimental state and #2469713: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary was committed just 15 days ago. I don't think these functions are worth keeping around but if you still don't agree then let me know @deprecate to which version?
Comment #7
dawehner@jibran
Well I kinda agree, but you know, I just try to avoid issues with the committers later. Sometimes it is just not worth the hussle.
Comment #8
jibranLet's RTBC it and assign it to @alexpott. I don't mind deprecating those at all.
Comment #9
almaudoh CreditAttribution: almaudoh commentedThese changes make sense to me and are an easier example to follow for writing Javascript Tests.
Comment #10
Wim LeersThis looks much simpler, much better. And to @dawehner's point at #2702233-25: [backport] Add JavaScript tests for Form API #states: required, visible, invisible, expanded, checked, unchecked, this removes Drupal-specific assertions in favor of just using Mink's.
Comment #11
alexpottI really think we should deprecate them - yes JTB is experimental but removing them unnecessarily breaks tests and obviously these tests will be new - that's a guaranteed way to annoy someone.
Comment #12
alexpottLet's remove them in 8.3.x.
Comment #13
Wim LeersGood point!
Comment #14
jibraninterdiff is against #2. RTBCing it because it is just a document change.
Comment #15
dawehnerThank you @jibran!
Comment #16
alexpottCommitted 0964a8f and pushed to 8.1.x and 8.2.x. Thanks!