In the .install file:
* Replace deprecated code
* Remove unused aliases
* Remove code which gives administrators all permissions as administrators already get all permissions.

CommentFileSizeAuthor
#2 multilingual-demo--install-file-cleanup-2708513-2.patch4.82 KBloopduplicate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

loopduplicate created an issue. See original summary.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Active » Needs review
FileSize
multilingual-demo--install-file-cleanup-2708513-2.patch4.82 KB
loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented 
  1. +++ b/multilingual_demo.install
@@ -5,16 +5,17 @@
-use Drupal\field\Entity\FieldStorageConfig;

    Removes unused aliases, adds some new ones, and alphabetizes them all. 

  2. +++ b/multilingual_demo.install
@@ -33,25 +34,22 @@ function multilingual_demo_install() {
-  // Enable all permissions for the administrator role.

    Removes code which gives admins all permissions because admins already have all permissions.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Fine with me if it still works :)

+++ b/multilingual_demo.install
@@ -33,25 +34,22 @@ function multilingual_demo_install() {
-  // Enable all permissions for the administrator role.
-  user_role_grant_permissions('administrator', array_keys(\Drupal::service('user.permissions')->getPermissions()));

Yeah not sure why was this here. It does not seem to be present in standard either.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

I did a little digging. It used to be in the standard profile.
In Implement admin role as a flag on the role storage, simplify permissions page, remove user_modules_installed, one of the changes was "Always pass all permissions check for [the admin] role."
See http://cgit.drupalcode.org/drupal/diff/core/profiles/standard/standard.install?id=1ee1495

Cheers,
loop

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Yay, looks good then :)

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

I'll do some testing.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

I tested and it looks good. Marking RTBC.

  • loopduplicate committed ece8f94 on 8.x-1.x 
    Issue #2708513 by loopduplicate, Gábor Hojtsy, Kristen Pol: Cleanup...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.