Problem/Motivation

#2701027: Drupal 8 UPGRADE.txt is misleading in many ways (in its name to begin with) removed a serial (Oxford) comma from README.txt. Our text guidelines require them: https://www.drupal.org/drupalorg/style-guide/content#english

Proposed resolution

Add it back so that it says:
Install, update, and maintain Drupal:

(I debated whether we should scope this as "Add serial commas where they are missing" but @alexpott and I agreed that it's not something that's testable, that we might as well just fix this small regression since it just happened, and also it's not in a PHP comment but a text file.)

Remaining tasks

Needs patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 add_back_serial_comma-2707095-3.patch495 bytesrichardbporter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented
Assigned: Unassigned » richardbporter
richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented
FileSize
add_back_serial_comma-2707095-3.patch495 bytes
richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented
Status: Active » Needs review
richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented
Issue summary: View changes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Thanks!

I read through the README, since I hadn't looked at it in a while, and there are no other serial comma problems.

I did notice that the develop section is woefully outdated, and will file a separate issue in the documentation component about that, but it's not related to this issue.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +Hilarious patch of the month
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

RC eligible as a doc change. Committed f870de1 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed f413763 on 8.2.x 
    Issue #2707095 by rbp, xjm: Add back serial comma in README.txt

  • alexpott committed f870de1 on 8.1.x 
    Issue #2707095 by rbp, xjm: Add back serial comma in README.txt

(cherry...
richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented

Thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.