Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Custom view modes are not migrating from D7 to D8, only those whose label is mapped in the migration template (e.g.default, full, teaser, etc).
Proposed resolution
The plugin for migrating the label is missing the bypass field from it's configuration (as it is in the mode migration).
Remaining tasks
Add bypass to the plugin for migrating label.
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#12 | 2706187-12.patch | 6.04 KB | alexpott |
#12 | 2706187-12.test-only.patch | 5.58 KB | alexpott |
#6 | custom_view_modes_not_migrating-2706187-6.patch | 6.04 KB | jofitz |
#6 | interdiff.txt | 668 bytes | jofitz |
Comments
Comment #2
jofitz CreditAttribution: jofitz at ComputerMinds commentedAdd bypass to the plugin for migrating label of view modes.
Comment #3
benjy CreditAttribution: benjy at PreviousNext commentedComment #4
jofitz CreditAttribution: jofitz at ComputerMinds commentedAdded tests.
Comment #6
jofitz CreditAttribution: jofitz at ComputerMinds commentedResolve test failures.
Comment #7
kevinquillen CreditAttribution: kevinquillen at Velir commentedStill getting this error after applying the patch.
a:5:{s:5:"%type";s:5:"Error";s:8:"@message";s:59:"Call to a member function getConfigDependencyName() on null";s:9:"%function";s:61:"Drupal\Core\Entity\EntityDisplayBase->calculateDependencies()";s:5:"%file";s:66:"/var/www/docroot/core/lib/Drupal/Core/Entity/EntityDisplayBase.php";s:5:"%line";i:274;}
Comment #8
kevinquillen CreditAttribution: kevinquillen at Velir commentedAfter reinstalling and reapplying the patch, it now works. I was able to migrate from D7 to D8 with everything (within reason) intact.
Comment #9
kevinquillen CreditAttribution: kevinquillen at Velir commentedLooks like this resolves the issue and my custom view modes and settings are retained from the D7 to D8 assisted upgrade. I did the migration 3 times and the result was consistent.
Comment #11
jofitz CreditAttribution: jofitz at ComputerMinds commentedLatest patch now passes tests again, suspect there may have been an issue with the testbot.
Re-setting to RTBC.
Comment #12
alexpottUploading a test only patch to ensure the expected tests fail. The -12.patch is a copy of the patch in #6
Comment #14
alexpottCommitted and pushed b83e2d78a616b6d85d275ad371fa7c6e9fc3b901 to 8.2.x and 7891569 to 8.1.x. Thanks!
The expected tests failed in #12 - nice work!