Follow-up to #2469721: Add functionality to store browser output to BrowserTestBase

Problem/Motivation

PHPStorm doesn't handle custom result printers well - https://youtrack.jetbrains.com/issue/WI-24808 is resolved. Drupal provides a result printer that links to the html output results for functional tests. Let's disable it for the time being.

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#5 2706113-5.patch1.26 KBalexpott
#5 2-5-interdiff.txt735 bytesalexpott
#2 2706113-2.patch1.16 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2706113-2.patch1.16 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Thank you!

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

+1 from me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2-5-interdiff.txt735 bytes
2706113-5.patch1.26 KB

So it turns out that you can customise the result printer on the command line using the --printer argument. So let's tell people about that. Unfortunately -- is not legal inside an XML comment. So now doing --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter" is like doing --verbose on run-tests.

  • catch committed a2380a7 on 8.2.x 
    Issue #2706113 by alexpott: Disable Drupal\Tests\Listeners\...

  • catch committed 36f026e on 8.1.x 
    Issue #2706113 by alexpott: Disable Drupal\Tests\Listeners\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

It's sad having to degrade the experience for everyone else due to a proprietary IDE (which I don't use personally). Hopefully they'll fix that bug soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Created #2870145: Set printerClass in phpunit.xml.dist.