As identified in #2628168: Clean up Entity Embed's data model, there is really no need to store the data-entity-label in the embedded HTML. It's only used to set the Dialog title, and we can do that programmatically in the form itself.

Comments

Dave Reid created an issue. See original summary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Active » Needs review

PR for review at https://github.com/drupal-media/entity_embed/pull/217

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

  • Dave Reid committed a40f556 on 8.x-1.x 
    Issue #2706045 by Dave Reid: Deprecated the data-entity-label attribute...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.