Problem/Motivation

When #2703637: Move non-dashboard functionality from crm_core_ui module lands will crm_core_ui include only dashboard functionality. Dashboards can easily be handled by Views, Panels, Page manager, ...

Proposed resolution

Kill crm_core_ui.

CommentFileSizeAuthor
#8 2703639-8.patch17.43 KBsanja_m
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

sanja_m’s picture

sanja_m CreditAttribution: sanja_m at MD Systems GmbH commented
Assigned: Unassigned » sanja_m

Assigning to me.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I would recommend that you wait with this.

Based on some discussions that I had with janez, it's possible that the remaining code will just go away.

sanja_m’s picture

sanja_m CreditAttribution: sanja_m at MD Systems GmbH commented
Status: Active » Postponed

Ok, postponed until #2703637: Move non-dashboard functionality from crm_core_ui module and will check with Janez after that if there's a need to do cleanups here.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented

I discussed this with @Berdir and @miro_dietiker. The only functionality that remains in crm_core_ui at this point is dashboard and it's configuration. D7 approach looks a bit strange in D8 world as we used to work with paths which are not really first class citizens any more. It would make much more sense to use routes instead, which would then likely cause a lot of UX problems.

I checked how AbleOrganizer implements it's dashboard and found out it is using panels. That further proves our thought that we could simply remove crm_core_ui entirely and rely on other modules (Views, Page manager, ...) to take over /crm-core route and implement the dashboard there.

Current approach seems strange anyway as we end up with exactly the same content being displayed on two unrelated routes (/crm-core and /crm-core/ableorganizer_dashboard in case of AbleOrganizer).

I propose that we keep simple list of links that we currently have on /crm-core, kill crm_core_ui and let other modules take responsibility of that route to build more powerful dashboards on it.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Issue summary: View changes
Status: Postponed » Active
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Title: Clean and rename crm_core_ui » Remove crm_core_ui
sanja_m’s picture

sanja_m CreditAttribution: sanja_m at MD Systems GmbH commented
Status: Active » Needs review
FileSize
2703639-8.patch17.43 KB

Added patch.

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks ok.

  • slashrsm committed 99dfaac on 8.x-1.x authored by sanja_m 
    Issue #2703639 by sanja_m, slashrsm, Berdir, CTaPByK: Remove crm_core_ui...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • slashrsm committed 99dfaac on 8.x-2.x authored by sanja_m 
    Issue #2703639 by sanja_m, slashrsm, Berdir, CTaPByK: Remove crm_core_ui...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.