Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The UI text for the Drupal Upgrade UI module needs some editing to follow the Interface text guidance.
Proposed resolution
Edit the text according to guidance on https://www.drupal.org/node/604342, including replacing "handbook" with "online documentation", and check whether "Drupal" should be mentioned here.
Remaining tasks
Edit the text as appropriate.
If the hook_help text has been edited prior to this issue, then check whether the help also needs changing.
User interface changes
This is a UI text change
API changes
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-2702531-7-10.txt | 2.1 KB | pguillard |
#10 | ui_text__drupal_pgrade-2702531-10.patch | 4.23 KB | pguillard |
#7 | interdiff-2702531-3-7.txt | 1.66 KB | pguillard |
#7 | ui_text__drupal_pgrade-2702531-7.patch | 4.18 KB | pguillard |
#3 | ui_text__drupal_pgrade-2702531-3.patch | 2.23 KB | pguillard |
Comments
Comment #2
pguillard CreditAttribution: pguillard commentedComment #3
pguillard CreditAttribution: pguillard commentedA first patch.
I didn't find anything more than the 2 suggestions, according to https://www.drupal.org/node/604342. Just one e.g. replaced by "for example", according to https://www.drupal.org/node/2637336.
I guess these 2 sentences are too long ?
Comment #5
ifrikComment #6
hauruck CreditAttribution: hauruck at UEBERBIT GmbH commentedThe Drupal Upgrade UI module also contain a useful quick link to the log messages related to migration:
/upgrade/log
Since it ends up at the Recent log messages page it doesn't get it's own menu item, but it would be nice to have it as a link in the UI text.
Comment #7
pguillard CreditAttribution: pguillard commentedTests should pass green.
@hauruck : I wonder where to add the message for #6. I suggest :
t('In case of errors or problems with the site, the Recent log messages page can be useful for debugging.', array(':dblog' => \Drupal::url('/upgrade/log')));
Comment #8
benjy CreditAttribution: benjy at PreviousNext commentedThe text changes seem good to me, setting to RTBC, not sure if patch still applies.
Comment #9
xjmThanks for working on this!
I actually do not think this link text change is good; "online documentation" is not specific enough to accessibly describe where the link leads. It should probably be something like "online documentation for Drupal site upgrades". Note that this module is slightly a special case because the handbook we are linking is not for the individual module itself; it is general documentation on how to upgrade between major versions.
We had also discussed trying to replace the confusing terminology of "Upgrade" vs. "Update" entirely, but that is out of scope for this issue. See #2709507: [META] Remove outdated references to "upgrade" from core.
@hauruck, maybe you could create a separate issue for your suggestion from #6 and then mention it here? Also see the parent issue #2678638: [META] Usability refinements for Migrate UI for other work we are doing to improve this UI.
The other string cleanups in this patch look fine to me, especially as incremental improvements for the experimental module. Thanks!
Comment #10
pguillard CreditAttribution: pguillard commentedAn update according to #9 suggestion, at least the one that is in scope of this issue.
Comment #11
pguillard CreditAttribution: pguillard commentedComment #12
scuba_flyI reviewed the #10 patch file
I applied the patch
I can see the text is changed when I do a /upgrade
Since this only a text change I think this can be RTBC.
Comment #13
ifrikThanks for the patch, and for the link to the online documentation.
Even if it's a bit counter-intuative the mentioning of "Drupal" can be removed because - unless I'm mistaken - the module also works to migrate sites from other Drupal distributions.
Comment #15
xjmThanks @scuba_fly for reviewing the patch!
This patch looks ready to me now. We can improve things further in #2678638: [META] Usability refinements for Migrate UI and #2709507: [META] Remove outdated references to "upgrade" from core.
Committed 8db2e4d and pushed to 8.2.x. Thanks!