Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I tested a Drupal 8 Standard installation + Yoast module and CKEditor plugins with need use Open Dialog function, like Insert Image, broke.
Exemple:
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff.txt | 698 bytes | KittenDestroyer |
| #10 | yoast_seo-ckeditor_dependency-2701091-10.patch | 1.79 KB | KittenDestroyer |
Comments
Comment #2
robertragas CreditAttribution: robertragas commentedIt has something to do with the dependency in yoast_seo.libraries.yml.
If you remove the
- ckeditor/drupal.ckeditor
- ckeditor/drupal.ckeditor.admin
It will work again, but not sure on the impact on removing those depedencies and if they are needed.
Comment #3
IT-CruSame error occurs when I use Link and LinkIt ckeditor plugin. When I disable the yoast seo field on article form it works again, but then we have no yoast seo hints.
Comment #4
stephenheron CreditAttribution: stephenheron commentedI am seeing the same issue with the Yoast plugin installed.
As per Roberts suggestion I removed 'ckeditor/drupal.ckeditor' and 'ckeditor/drupal.ckeditor.admin' libraries and it now works. However I am seeing some strange behaviour with the Snippet editor. When I use any of the dialogs in CKEditor I get an additional Snippet editor appearing.
I tried to debug it but it seems that most of JS is in 'yoast-seo.min.js' which is minified so it makes it very difficult to debug.
Any ideas when/if this is getting fixed?
Comment #5
Joao Informatico madrid CreditAttribution: Joao Informatico madrid commented+1
Comment #6
Shadowcub CreditAttribution: Shadowcub commentedI'm also having the same issue with Linkit, plus the default hyperlink and image uploader.
Comment #7
KittenDestroyer CreditAttribution: KittenDestroyer as a volunteer commentedAs I've investigated, we do not need to include ckeditor/drupal.ckeditor dependency in libraries.yml. This library loads by default when CKEditor field is present on a node edit page. Calling dependency one more time is what causes this issue. Please review patch I've attached.
Comment #8
KittenDestroyer CreditAttribution: KittenDestroyer as a volunteer commentedChanging issue status to Needs review
Comment #9
robertragas CreditAttribution: robertragas commentedHello KittenDestroyer,
With this patch is does work indeed, but there is another problem that comes up.
When you use the ckeditor opendialog , like the hyperlink/image etc. it duplicates the snippet editor.
Comment #10
KittenDestroyer CreditAttribution: KittenDestroyer as a volunteer commentedI've updated patch to include changes to yoast_seo.edit_node.js. It should fix duplicated analyzer objects on node edit.
Comment #12
robertragas CreditAttribution: robertragas commentedThanks for the patch! Forgot to update the ticket, but its approved and merged in.
Comment #14
AnybodyHas this ever been commited to stable? I had the same bug with 1.3...
Comment #15
jeromewiley CreditAttribution: jeromewiley commentedInstalled version 1.3 as of about 2-3 weeks ago, appears to be unpatched (experiencing identical original symptoms from 2016 as reported above.)
Also, cannot uninstall module because "field is in use."
Our co-worker has spent countless hours inputting data.
Additionally, our co-workers are not able to add links to content, because CKEditor tools are disabled.
ckeditor.openDialog is not a function
Maybe I can inspect the patch visually and attempt to place the code into our local 1.3 install?
Comment #16
AnybodyThank you, @RobertRagas, are you still active and could you please reopen the issue and ensure the patch is applied to latest dev and stable?
Otherwise we'll have to create a linking issue.
Comment #17
KingdutchFor anyone that currently encounters this issue.
I think this has been fixed in a previous 1.x version but it may have sneaked in inadvertently later. This issue has been resolved in the 2.x branch which is the version of this module that is currently supported and for which development will be continued. 2.x is usable at this moment but remains in alpha because some clean-up is required and some more changes may be needed that require increased testing during updates in order to make future features possible.