Problem/Motivation

Enable workbench_moderation
Visit /admin/content
All pager links are borked

<a href="?status=All&amp;type=All&amp;title=&amp;langcode=All&amp;=Filter&amp;page=0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0" title="Current page">
            <span class="visually-hidden">
              Current page
            </span>1</a>

Check all those ,0s - happens with every pager on the site - including but not limited to

  • search results
  • taxonomy term views

Basically any page that uses the node param converter ends up in \Drupal\workbench_moderation\ModerationInformation::getLatestRevisionId and things get nasty

Patch coming

Proposed resolution

Use range() instead of pager(). We only want to limit the query, not initialize Drupal's pager stuff.

Remaining tasks

Review

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2698085-pager-issues.patch2.3 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for amaysim Australia Ltd. commented
Status: Active » Needs review
FileSize
2698085-pager-issues.patch2.3 KB

Patch

Crell’s picture

Crell CreditAttribution: Crell at Palantir.net for Acquia commented
Status: Needs review » Reviewed & tested by the community

Guh. Entity API...

Thanks, larowlan. I'll commit this probably tomorrow, definitely before the next beta.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Actually, its DBTNG :)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Actually, its the point where the two meet. Carry on.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

  • larowlan committed 1779c90 on 8.x-1.x 
    Issue #2698085 by larowlan: \Drupal\workbench_moderation\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.