With a fresh checkout of Entity Embed and Entity Browser, attempting to embed an entity using CKEditor fails with:

Argument 1 passed to Drupal\entity_browser\Plugin\EntityBrowser\Display\Modal::displayEntityBrowser() must implement interface Drupal\Core\Form\FormStateInterface, none given, called in /entity_embed/src/Form/EntityEmbedDialog.php on line 211

It looks like Entity Browser's displayEntityBrowser() method must now be passed $form_state.

CommentFileSizeAuthor
#2 2696261-2.patch3.62 KBDevin Carlson
#2 2696261-2-tests-only.patch2.81 KBDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson created an issue. See original summary.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
2696261-2-tests-only.patch2.81 KB
2696261-2.patch3.62 KB

A patch to pass $form_state to displayEntityBrowser().

Uploading here in addition to Github to verify that the tests work.

Status: Needs review » Needs work

The last submitted patch, 2: 2696261-2.patch, failed testing.

The last submitted patch, 2: 2696261-2-tests-only.patch, failed testing.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Needs work » Needs review

The testbot doesn't seem to pick up new test dependencies or check requirements before running tests.

  • Devin Carlson committed 509fc57 on 8.x-1.x 
    Issue #2696261 by Devin Carlson: AJAX errors when embedding entities...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Status: Needs review » Fixed

Merged GitHub pull request: https://github.com/drupal-media/entity_embed/pull/208

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.