Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When the user puts in the wrong the password the reloaded page shows "Have you forgotten your password?" which can be instead written as "Forgotten your password?"
as seen across many the web on many other sites.
Proposed Resolution
Change the text to "Forgotten your password?"
Before
After
Comment | File | Size | Author |
---|---|---|---|
#21 | ForgotPassword.png | 28.24 KB | joyceg |
#19 | 2691025-18.patch | 2.66 KB | therealssj |
#12 | After_patch.JPG | 70.27 KB | Truptti |
#12 | Patch_applied.JPG | 67.89 KB | Truptti |
#12 | Before_patch.JPG | 84.1 KB | Truptti |
Comments
Comment #2
therealssj CreditAttribution: therealssj commentedHere is a patch for it.
Comment #3
therealssj CreditAttribution: therealssj commentedComment #5
therealssj CreditAttribution: therealssj commentedMissed the change at one place.
Comment #6
therealssj CreditAttribution: therealssj commentedComment #7
ajalan065 CreditAttribution: ajalan065 as a volunteer and at Google Summer of Code commentedComment #8
ajalan065 CreditAttribution: ajalan065 as a volunteer and at Google Summer of Code commentedSorry, I ended up working on this in parallel to @therealssj. Saw the previous test failed, so uploaded the patch
Comment #9
nicrodgersI'm not sure I agree with the motivation of this patch. Yes, it can be shorter, but the shorter version doesn't sound nearly as friendly or helpful. What's the benefit of this change?
Comment #10
therealssj CreditAttribution: therealssj commented@nicrodgers The main motivation was the fact that out of all websites that i have ever registered on drupal was the only one which displayed "Have you forgotten your password". mostly it would be something like 'Forgot your password?', 'Forgot?', 'Lost your password?' or as above 'Forgotten your password?'
As for benefit, it shorter and coveys the same message?
I was more in favor of 'Forgot your password?' though.
Comment #11
cilefen CreditAttribution: cilefen commentedComment #12
Truptti CreditAttribution: Truptti at Axelerant commentedVerified the patch in #7 on drupal 8.2.x local site.On applying the patch forgot password message is displayed as
'Unrecognized username or password. Forgotten your password?'
Attached snapshot for reference.Marking as Reviewed and Tested by community.
Comment #13
Truptti CreditAttribution: Truptti at Axelerant commentedComment #14
catchfwiw I think 'Forgotten your password?' is friendlier.
'Have you forgotten your password?' can sound a bit passive aggressive, like 'Have you forgotten who you're talking to?', especially if you know you mis-typed it and haven't forgotten it at all. Speaking from experience :(
Since this is something that probably millions of people see a year, tagging for usability review.
Comment #15
yoroy CreditAttribution: yoroy at Roy Scholten commentedNice little tweak, I like it. Agree with @catch the shorter version is friendlier and less assuming. I don't know about "forgot" vs. "forgotten".
Comment #16
catchI'd go for 'Forgot'. I don't think there's much in it, but saves characters. It also allows for having temporarily forgotten the password - like 'I forgot my keys', whereas forgotten implies a more permanent state.
Comment #17
yoroy CreditAttribution: yoroy at Roy Scholten commentedOk lets do that. One more updated patch please :)
Comment #18
catchWhile we're here, google informs me there was a discussion about this on stackexchange, and it slightly preferred 'Forgot password?'
http://english.stackexchange.com/questions/670/is-it-correct-to-use-forg...
Comment #19
therealssj CreditAttribution: therealssj commentedHere :)
Comment #20
yoroy CreditAttribution: yoroy at Roy Scholten commentedComment #21
joyceg CreditAttribution: joyceg commentedThe patch applies well.
Good work.
Comment #22
yoroy CreditAttribution: yoroy at Roy Scholten commentedI saw the same as in #21 using simplytest.me. Good to go!
Comment #24
catchCommitted 0905f0f and pushed to 8.2.x. Thanks!