Problem/Motivation

The description of the Inline Form Errors module has been updated to:

Enabling inline form errors improves accessibility of web forms errors so that they meet WCAG 2.0 requirements. Unfortunately, some functionality within Forms API may not work as desired.

There are a few things to improve with this text:

  1. It uses the words "unfortunately" and "desired", which is emotional language that does not comply with our content style guidelines. We should simply state the limitations of the experimental module, not apologize for them. Reference: https://www.drupal.org/node/604342 "As desired" is also vague; who desires it? What do they desire?
  2. The module does not need to tell you that enabling the module does what the module does. It should just tell you what the module does.
  3. "Forms API" is not something the site user should know or care about.
  4. It is overly long.

Proposed resolution

Make the description more declarative.

This issue is filed against 8.1.x because it involves a UI text improvement, which is allowed during the beta, and is for an experimental module.

Remaining tasks

Patch needs review.

User interface changes

Inline Form Errors text shortened to:

Adds WCAG 2.0 accessibility compliance for web form errors. Some form functionality may not work with this experimental module.

API changes

Data model changes

CommentFileSizeAuthor
inline-description.patch760 bytesxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

Issue tags: +Needs usability review

I know a lot of usability work has gone into module descriptions and help page text, so this might be an area we should always get usability signoff on.

xjm’s picture

xjm’s picture

Issue summary: View changes
yoroy’s picture

Big improvement for the right reasons. It’s a pity we can’t be more precise than saying "some functionality" (argh, which?!).

xjm’s picture

Thanks @yoroy. I tried to think of a way to summarize the bugs with it rather than just "some functionality" but did not come up with anything more straightforward than "this experimental module does not work properly yet." #2346773: Details form element should open when there are errors on child elements and #2509268: Inline errors repeated on child elements in module uninstall form and #2687249: Improve inline form errors for file upload fields are examples -- a wide selection of bugs in many flavors!

yoroy’s picture

Status: Needs review » Reviewed & tested by the community

Understandable. It's something to keep in mind with experimental modules: how many discaimers and when/where?

The last sentence can be read as if this module breaks forms that would otherwise work. Is that true?

yoroy’s picture

Status: Reviewed & tested by the community » Needs review
xjm’s picture

The last sentence can be read as if this module breaks forms that would otherwise work. Is that true?

Yes, I'd say it kind of does based on those outstanding bug reports. It will make some validation errors cause forms to seem impossible to submit (because the user cannot find the validation error), and make a confusing mess of others.

(FWIW, I'm going to encourage that the module needs to be either fixed up for 8.2.x or taken back out of core, since those bugs haven't really made progress since release.)

yoroy’s picture

Status: Needs review » Reviewed & tested by the community

Thanks. This text change is rtbc then :)

  • catch committed 7a4396a on 8.2.x
    Issue #2688273 by xjm, yoroy: Remove emotional language from Inline Form...

  • catch committed f8dba3d on 8.1.x
    Issue #2688273 by xjm, yoroy: Remove emotional language from Inline Form...
catch’s picture

Status: Reviewed & tested by the community » Fixed

OK that looks a lot better. This crossed my mind with the original patch, but also I can't see anyone actually trying to use this module at all yet, so couldn't really think of what to do with it.

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.