Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The MessageForm class on save() first sends the MailMessages and then it saves the message entity.
I need to send in the emails a URL to see the message entity, but I cannot do it because the message is not persisted yet (it doesn't have an ID).
Comment | File | Size | Author |
---|---|---|---|
#12 | Send-before-saving-2687507-6-12.patch | 1.18 KB | sidharthap |
#6 | Send-before-saving-2687507-6-8.patch | 1.2 KB | ajalan065 |
#3 | Send-before-save-2687507-3-8.patch | 1.2 KB | ajalan065 |
#2 | contact-message_form_save-2687507-1.patch | 1.32 KB | nicobot |
Comments
Comment #2
nicobot CreditAttribution: nicobot as a volunteer commentedPlease find attached my proposal.
Comment #3
ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commentedHope this passes
Comment #4
ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commentedComment #6
ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commentedGo Test Bot..
Comment #7
larowlanI assume you're using contact storage here?
Comment #8
nicobot CreditAttribution: nicobot as a volunteer commentedYes, I'm also using contact_storage
Comment #10
BerdirMakes sense to me, but I'm wondering if we can somehow test this. We have a test to store messages, but we have no token support in core to put the Id into the label, without that, I guess it's not really possible to write a test, except writing a unit test.
Not sure if it's worth it, I'd say no :)
Comment #11
alexpottNeeds a reroll.
I'm happy to commit this code move without a test. Let's get this in 8.3.x first. It would seem eligible for 8.2.x as well to me.
Comment #12
sidharthapReroll patch as per #11
Comment #13
BerdirBack to RTBC then.
Comment #14
alexpottI'd say this is a task - not really a bug here. Hence only committing to 8.3.x. Committed 9b7b2ee and pushed to 8.3.x. Thanks!