Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The current patch in #2456477: Convert deprecated \Drupal\simpletest\KernelTestBase tests to KernelTestBaseNG is getting big, @dawehner and I think it's time to move it to a separate issue so we can get it committed.
Proposed resolution
This converts all remaining kernel tests in those modules (including EntityUnitTestBase).
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#11 | kernel-tests-a-i-2686207-11-interdiff.txt | 2.18 KB | Berdir |
#11 | kernel-tests-a-i-2686207-11.patch | 92.16 KB | Berdir |
#9 | kernel-tests-a-i-2686207-9.patch | 91.22 KB | Berdir |
#8 | kernel-tests-a-i-2686207-8-interdiff.txt | 768 bytes | Berdir |
#8 | kernel-tests-a-i-2686207-8.patch | 91.29 KB | Berdir |
Comments
Comment #2
BerdirComment #3
BerdirMoved the config tests out of the config module.
Comment #4
BerdirAnd addressing #52.2 from the other issue.
Comment #8
BerdirThis should fix the test fail.
Comment #9
BerdirRerolled. Still applied with git apply -3.
Comment #10
dawehnerIf we change these lines we could use
assertContains
directlyComment #11
BerdirSure. Updated all in that test. Certainly results in much better fail output.
Comment #12
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedLooks pretty straightforward to me. Just a couple of comments over 80 chars that can be fixed on commit :)
Here.
And here.
Comment #13
alexpottI think this exist because we used to case booleans to '0' and '1' - a long time ago - all config was cast to strings. I think we should file a follow up to fix this test to always use assertSame and fix the confusing documentation.
We should file a followup to fix this test to not mention
system_config_schema_info_alter()
and update the documentation about themes because it is confusing (I probably wrote it).This is neat - we can use classes from modules that are not installed :)
How this is a removed - pointlessness?
Comment #14
Berdir1. #2695221: Remove ConfigFileContentTest and spread its ashes over ConfigCRUDTest and ConfigStorageTestBase
2. #2695223: Fix tests using \Drupal\config_test\TestInstallStorage to only test core configuration
3. Fixed.
4. As discussed, explained in #2456477-48: Convert deprecated \Drupal\simpletest\KernelTestBase tests to KernelTestBaseNG (point 9)
Comment #15
alexpottCommitted 76cf6e2 and pushed to 8.1.x and 8.2.x. Thanks!
Fixed on unused use on commit and stuff from #12
Comment #17
alexpott