Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
For some reason I can't get them working from the UI. I stuck a debugger on it and I believe the test runner batch gets tangled up with the sitemap runner batch. I've tried them from drush and I also get 6 fails.
Proposed resolution
Fix tests
Remaining tasks
Patch.
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screen Shot 2016-03-12 at 7.33.16 AM.png | 545.06 KB | Sam152 |
| #3 | 2685407-fix-tests-3.patch | 1.35 KB | Sam152 |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedNot totally sure why yet, but looking into it.
Comment #3
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedFew issues, the config is loaded in the constructor, so the service needs reloading after a change to config, settings, or the simple_sitemap table. The other issue was that the node was missing a type. Fixed in the drush runner, haven't check the web runner yet.
Comment #4
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedScreenshot of positive tests results from a drush run.
Comment #5
gbyte CreditAttribution: gbyte as a volunteer and commentedThe reloading was actually done by the initialize() method in Simplesitemap class - we removed this here. Now I know why it was there in the first place... We need those tests badly. ;)
Comment #6
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedBut initialize was only ever called from the constructor, so I think the outcomes would have been the same?
Comment #7
gbyte CreditAttribution: gbyte as a volunteer and commentedIt was also called on very save_config().
Anyway, I guess recreating the service is as good.
Comment #9
gbyte CreditAttribution: gbyte as a volunteer and commented