Problem/Motivation

I think it makes sense for this to be a service. It makes it easier to test/instantiate/inject and override.

Proposed resolution

Convert it to a service.

Remaining tasks

Write a patch.

User interface changes

None.

API changes

Alterations in the signature for the Simplesitemap class.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Attached is a first pass. Now that the generator can be injected into controllers and forms, there is probably some follow-up work that can be done with this, but will leave the changes as fairly minimal for now.

Sam152’s picture

Status: Active » Needs review
Sam152’s picture

Here is one that actually applies to HEAD.

gbyte’s picture

Status: Needs review » Fixed

I was planning on going there, glad you made the first step. I had to alter the patch slightly to avoid php errors. I'm going to mark this as fixed, but it would be great if you could follow up on #2 as soon as you have any ideas.

Thanks for your contribution!

Sam152’s picture

Not a problem at all. I'll open the relevant issues.

  • gbyte.co committed d6600e4 on 8.x-2.x authored by Sam152
    Issue #2684757 by Sam152: Convert Simplesitemap class into a service
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.