Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
I think it makes sense for this to be a service. It makes it easier to test/instantiate/inject and override.
Proposed resolution
Convert it to a service.
Remaining tasks
Write a patch.
User interface changes
None.
API changes
Alterations in the signature for the Simplesitemap class.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2684757-sitemap-generator-service-4.patch | 8.75 KB | Sam152 |
#2 | 2684757-sitemap-generator-service-2.patch | 8.27 KB | Sam152 |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedAttached is a first pass. Now that the generator can be injected into controllers and forms, there is probably some follow-up work that can be done with this, but will leave the changes as fairly minimal for now.
Comment #3
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #4
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedHere is one that actually applies to HEAD.
Comment #5
gbyte CreditAttribution: gbyte as a volunteer and commentedI was planning on going there, glad you made the first step. I had to alter the patch slightly to avoid php errors. I'm going to mark this as fixed, but it would be great if you could follow up on #2 as soon as you have any ideas.
Thanks for your contribution!
Comment #6
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedNot a problem at all. I'll open the relevant issues.