Problem/Motivation

JavaScript code must be consistent and free from syntax error and leaking variables and that it can be properly minified.

Proposed resolution

Detect errors and potential problems in JavaScript code with ESLint tool and fix them.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 eslint-google_analytics.patch18.9 KBCTaPByK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

CTaPByK created an issue. See original summary.

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK at MD Systems GmbH commented
Status: Active » Needs review
FileSize
eslint-google_analytics.patch18.9 KB

Changes made here is required by default ESLint rules:
*spaced-comment
*quotes
*valid-jdoc

hass’s picture

hass CreditAttribution: hass commented

The code was eslint validated and was clean for sure. Has any core rule changed or why have you changed all these code?

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Postponed (maintainer needs more info)

  • hass committed e7d45bc on 8.x-2.x 
    Issue #2684269 by hass: Add curly quotes to param types
hass’s picture

hass CreditAttribution: hass commented
Status: Postponed (maintainer needs more info) » Fixed

No feedback for the rest of the changes. Closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.