Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.https://api.drupal.org/api/drupal/core%21modules%21system%21src%21EventS...
Use a higher priority than \Drupal\field_ui\Routing\RouteSubscriber or \Drupal\views\EventSubscriber\RouteSubscriber to ensure we add the option to their routes.
@todo https://www.drupal.org/node/2158571
The statement is confusing because the subscriber actually has lower priority (-200) than Field UI subscriber (-100) or Views subscriber (-175). Symfony priorities don't work same way as weights in some Drupal components.
An optional priority integer (higher equals more important and therefore that the listener will be triggered earlier) that determines when a listener is triggered versus other listeners (defaults to 0).
http://symfony.com/doc/current/components/event_dispatcher/introduction....
We might also want to remove todo statement because the referenced issue is fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff-2682367-3-7.txt | 812 bytes | leolandotan |
| #7 | fix-AdminRouteSubscriber-getSubscribedEvents-comment-2682367-7.patch | 1007 bytes | leolandotan |
| #3 | fix-AdminRouteSubscriber-getSubscribedEvents-comment-2682367-3.patch | 900 bytes | leolandotan |
Comments
Comment #2
Chi CreditAttribution: Chi commentedComment #3
leolandotan CreditAttribution: leolandotan as a volunteer and at Promet Source commentedHere I have updated the method's comments as @Chi stated. Hope everything is in order.
Thanks!
Comment #4
leolandotan CreditAttribution: leolandotan as a volunteer and at Promet Source commentedComment #5
Chi CreditAttribution: Chi commented@leolando.tan, it looks like we can keep 'option' word on the second line since it doesn't break 80 characters limit.
Comment #6
Devaraj johnson CreditAttribution: Devaraj johnson as a volunteer and at Ameex-Drupal Geeks commentedComment #7
leolandotan CreditAttribution: leolandotan as a volunteer and at Promet Source commented@Chi, Oh yeah! Just right at the 80 character limit! Didn't notice that. This contains the simple revision.
Thanks!
Comment #8
leolandotan CreditAttribution: leolandotan as a volunteer and at Promet Source commentedComment #9
Chi CreditAttribution: Chi commentedLooks fine to me.
Comment #13
catchCommitted/pushed to all three 8.x branches, thanks!