Problem/Motivation

Using sh build.sh -s to build a CKEditor release for Drupal adds a .jscsrc and a .jshintrc file to the ckeditor folder. These files are not related to the usage of CKEditor itself.

Proposed resolution

Ignore .jscsrc and .jshintrc in build-config.js

Remaining tasks

Do it
Manual test it

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2680737-2.patch466 bytesthpoul
#2 after.png12.18 KBthpoul
#2 before.png12.94 KBthpoul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thpoul created an issue. See original summary.

thpoul’s picture

thpoul CreditAttribution: thpoul as a volunteer commented
Status: Active » Needs review
FileSize
before.png12.94 KB
after.png12.18 KB
2680737-2.patch466 bytes

Before:
Before

After:
After

thpoul’s picture

thpoul CreditAttribution: thpoul as a volunteer commented
Issue summary: View changes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at erdfisch commented
Status: Needs review » Reviewed & tested by the community

Yup, verified that they appear in the generated output in HEAD and not with the patch. Looks good!

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Minor
Issue tags: +Quickfix

+1. They added these to their repo recently.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed f4940f7 and pushed to 8.1.x and 8.2.x. Thanks!

Not sure it is worth putting in 8.0.x as we're unlikely to build a new ckeditor for it.

  • alexpott committed 181b4bb on 8.2.x 
    Issue #2680737 by thpoul: Remove unrelated CKEditor repository structure...

  • alexpott committed f4940f7 on 8.1.x 
    Issue #2680737 by thpoul: Remove unrelated CKEditor repository structure...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Not sure it is worth putting in 8.0.x as we're unlikely to build a new ckeditor for it.

Agreed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.