The processors aren't tested very well in the integration test suite; they should have extra tests in the integration test. Attached patch adds a new test to do that.

CommentFileSizeAuthor
#16 expand_processor_test-2680301-16.patch20.58 KBborisson_
#16 interdiff.txt1.88 KBborisson_
#14 expand_processor_test-2680301-14.patch19.52 KBborisson_
#14 interdiff.txt8.29 KBborisson_
#13 expand_processor_test-2680301-13.patch18.37 KBborisson_
#13 interdiff.txt905 bytesborisson_
#11 expand_processor_test-2680301-11.patch18.47 KBborisson_
#11 interdiff.txt5.85 KBborisson_
#10 expand_processor_test-2680301-7.patch13.96 KBborisson_
#7 expand_processor_test-2680301-7.patch13.96 KBborisson_
#4 expand_processor_test-2680301-4.patch4.43 KBborisson_
#4 interdiff.txt4.43 KBborisson_
processor-integration-test.patch14.33 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, processor-integration-test.patch, failed testing.

The last submitted patch, processor-integration-test.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff.txt4.43 KB
expand_processor_test-2680301-4.patch4.43 KB

Status: Needs review » Needs work

The last submitted patch, 4: expand_processor_test-2680301-4.patch, failed testing.

The last submitted patch, 4: expand_processor_test-2680301-4.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
expand_processor_test-2680301-7.patch13.96 KB

Status: Needs review » Needs work

The last submitted patch, 7: expand_processor_test-2680301-7.patch, failed testing.

The last submitted patch, 7: expand_processor_test-2680301-7.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
expand_processor_test-2680301-7.patch13.96 KB

Reuploaded patch from #7.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
FileSize
interdiff.txt5.85 KB
expand_processor_test-2680301-11.patch18.47 KB

More test cases.

Status: Needs review » Needs work

The last submitted patch, 11: expand_processor_test-2680301-11.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff.txt905 bytes
expand_processor_test-2680301-13.patch18.37 KB

meh, sorting changed between php5 and php7 - so we should use a less strict test and accept that.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
FileSize
interdiff.txt8.29 KB
expand_processor_test-2680301-14.patch19.52 KB

Reviewed the documentation and added an extra test case. We should add extra test cases for the remaining processors but those are a little bit more difficult so I'd say we do those as follow-ups?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work

Now that #2596435: Create Facet processors - do not display active items is committed, this needs a test for that processor as well.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.88 KB
expand_processor_test-2680301-16.patch20.58 KB

Added that test as well.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Fixed

More tests == good, committed.

  • borisson_ committed 8474b9f on 8.x-1.x 
    Issue #2680301 by borisson_: Expand processor test coverage

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.