Problem/Motivation

I checked many field's help text (#description) from core. I got one sentence which has no full stop (.).

I know this is very simple, but my thought our all sentence is ok except this sentence.

Need a full stop image

Proposed resolution

I think, This sentence need a full stop(.).

CommentFileSizeAuthor
#2 need-full-stop-for-description-fields-help-text-in-add-comment-type-section-2678550-2.patch786 bytesimrancluster
need-full-stop-at-add-comment-type.png50.11 KBimrancluster
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

imrancluster created an issue. See original summary.

imrancluster’s picture

imrancluster CreditAttribution: imrancluster commented
FileSize
need-full-stop-for-description-fields-help-text-in-add-comment-type-section-2678550-2.patch786 bytes

Here is a small patch.

imrancluster’s picture

imrancluster CreditAttribution: imrancluster commented
Status: Active » Needs review
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Druid commented
Status: Needs review » Reviewed & tested by the community

Looks good! I think 8.1.x is the correct version, considering this is a minor break for translations.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: need-full-stop-for-description-fields-help-text-in-add-comment-type-section-2678550-2.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Druid commented
Status: Needs work » Reviewed & tested by the community

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

  • catch committed 85ef01d on 8.2.x 
    Issue #2678550 by imrancluster: Need full stop (.) for description field...

  • catch committed 1f4efc9 on 8.1.x 
    Issue #2678550 by imrancluster: Need full stop (.) for description field...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.