Problem/Motivation

$list->getDataDefinition() has missing docs that tells you it's going to be a ListDataDefinitionInterface. Same for Complex Data and ComplexDataDefinitionInterface. That way IDE cannot auto-complete on that either.

Proposed resolution

Add it.

Remaining tasks

User interface changes

API changes

- (Method is already on parent, but without the right @return type)

Data model changes

CommentFileSizeAuthor
#2 d8_typed_data_interface_docs.patch1.32 KBfago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Active » Needs review
FileSize
d8_typed_data_interface_docs.patch1.32 KB

here is a patch

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Issue summary: View changes

Note: This is no API change at all as the method already existing in the parent interface: TypedDataInterface.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good :)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x and 8.0.x. Thanks!

  • catch committed ad0a90f on 8.2.x 
    Issue #2677672 by fago: Improve docs of getDataDefinition for lists and...

  • catch committed 90c3be6 on 8.1.x 
    Issue #2677672 by fago: Improve docs of getDataDefinition for lists and...

  • catch committed 478bbd5 on 8.0.x 
    Issue #2677672 by fago: Improve docs of getDataDefinition for lists and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.