Problem/Motivation

Builder plugins have been converted into classes or derivers they are no longer needed

Proposed resolution

  • Remove migrate.migration_builder service and classes
  • Remove plugin.manager.migrate.builder service and classes
  • Delete all the plugins which have a namespace that contains Plugin\migrate\builder - there are 8 atm

Remaining tasks

User interface changes

None

API changes

The API changes occurred in #2625696: Make migrations themselves plugins instead of config entities

Data model changes

The data model changes occurred in #2625696: Make migrations themselves plugins instead of config entities

CommentFileSizeAuthor
#22 2676258-23.patch35.35 KBbenjy
#15 2676258-15.patch34.93 KBbenjy
#11 2676258-11.patch34.93 KBalexpott
#11 8-11-interdiff.txt5.61 KBalexpott
#8 2676258-8.patch29.64 KBbenjy
#6 2676258-6.patch26.87 KBbenjy
#5 2676258-review-5-do-not-test.patch24.69 KBbenjy
#4 2676258-full-4.patch182.6 KBbenjy
#4 2676258-review-do-not-test.patch23.64 KBbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Related issues: +#2668436: Figure out what happens to installMigrations

As migrate.migration_builder is used in MigrateDrupalTestBase::installMigrations() I think we need to remove that here too so this will make #2668436: Figure out what happens to installMigrations superfluous.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Active » Needs review
FileSize
2676258-review-do-not-test.patch23.64 KB
2676258-full-4.patch182.6 KB
benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2676258-review-5-do-not-test.patch24.69 KB

Remove the builder interface as well.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2676258-6.patch26.87 KB

Re-rolled against 8.1.x and removed the migration builder and migration template services + interfaces.

Status: Needs review » Needs work

The last submitted patch, 6: 2676258-6.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs work » Needs review
FileSize
2676258-8.patch29.64 KB

Removed the template test as well.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Druid commented
Issue tags: +BC break
chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Title: Nuke builder plugins » Nuke builder plugins and migration storage
Status: Needs review » Reviewed & tested by the community
Issue tags: -BC break

Migrate is experimental, it's not under the BC umbrella.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs review
FileSize
8-11-interdiff.txt5.61 KB
2676258-11.patch34.93 KB

I think there's some stuff missing.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

Thanks alexpott, I was wondering how I missed that but then I realised I had it in #4 and the merge after the plugins patch messed up.

+1 for RTBC from me but I created the first patch.

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Status: Needs review » Reviewed & tested by the community

Let's try this again :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs re-roll

Needs a re-roll.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs work » Needs review
FileSize
2676258-15.patch34.93 KB

Re-rolled.

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

  • catch committed f71ec89 on 8.1.x 
    Issue #2676258 by benjy, alexpott: Nuke builder plugins and migration...

  • xjm committed 803834c on 8.1.x 
    Revert "Issue #2676258 by benjy, alexpott: Nuke builder plugins and...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Fixed » Needs work

Had to revert this unfortunately. See #2625696: Make migrations themselves plugins instead of config entities.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs work » Needs review
FileSize
2676258-23.patch35.35 KB

Re-rolled.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Nice less code!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.2.x-dev » 8.1.x-dev

Committed/pushed to 8.2.x, thanks!

Leaving RTBC against 8.1.x.

The last submitted patch, 4: 2676258-review-do-not-test.patch, failed testing.

The last submitted patch, 5: 2676258-review-5-do-not-test.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: -Needs re-roll +beta target, +8.1.0 release notes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: -8.1.0 release notes
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Cherry-picked to 8.1.x.

  • catch committed db464d8 on 8.2.x 
    Issue #2676258 by benjy, alexpott: Nuke builder plugins and migration...

  • catch committed b9cb2e3 on 8.1.x 
    Issue #2676258 by benjy, alexpott: Nuke builder plugins and migration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning at Acquia commented

How does one create dynamic migrations now?