The title says it all. This could be cause redirect issues by preventing the correct headers from being sent.

I don't know if this has been fixed in 5.x-dev, as I couldn't find the CVS path. D6+ is fine.

Regards

Alan

CommentFileSizeAuthor
#5 phptemplate-engine-remove-closing-php-tag-D5.patch778 bytesbrianV
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gpk’s picture

gpk CreditAttribution: gpk commented
Status: Active » Postponed (maintainer needs more info)

>phptemplate.php
Erm, I don't know that file !

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Title: Closing php tag and trailing white space in phptemplate.php » Closing php tag and trailing white space in template.php [Edit: phptemplate.engine]

Duh, sorry I was in the middle of something else at the time.

"themes\engines\phptemplate\phptemplate.engine"

gpk’s picture

gpk CreditAttribution: gpk commented
Status: Postponed (maintainer needs more info) » Active

Here's the CVS link http://cvs.drupal.org/viewvc.py/drupal/drupal/themes/engines/phptemplate...

The closing ?> went in revision 1.62.

It's still there in 5.x-dev (1.54.2.2).

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Version: 5.7 » 5.x-dev
brianV’s picture

brianV CreditAttribution: brianV commented
Status: Active » Reviewed & tested by the community
Issue tags: +Quick fix
FileSize
phptemplate-engine-remove-closing-php-tag-D5.patch778 bytes

Patch attached.

Setting directly to RTBC since it is trivial.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.x.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.