Replace deprecated usage of entity_create('node') with a direct call to Node::create() in comment,datetime,editor,field,hal,system,taxonomy,views

Hi,
I have patched to overwrite older entity_create() function by Node::create() on the patch deprecation_entity_create_2672600_6.patch

Thanks & Regards
Arunkumar K

Thanks, @arunkumark

1. +++ b/core/modules/comment/src/Plugin/views/field/NodeNewComments.php
   @@ -162,10 +162,10 @@ public function preRender(&$values) {
   +        'type' => $node_type
   
   +++ b/core/modules/comment/src/Tests/CommentBookTest.php
   @@ -38,11 +38,11 @@ protected function setUp() {
   +      'body' => 'Book body'
   
   +++ b/core/modules/editor/src/Tests/EditorFileUsageTest.php
   @@ -107,12 +107,12 @@ public function testEditorEntityHooks() {
   +      'uid' => 1
   
   +++ b/core/modules/field/src/Tests/Number/NumberFieldTest.php
   @@ -436,16 +436,12 @@ function testNumberFormatter() {
   +      $integer_field => ['value' => $random_integer]
   
   +++ b/core/modules/hal/src/Tests/EntityTest.php
   @@ -60,19 +60,19 @@ public function testNode() {
   +        'format' => $this->randomMachineName()
   +      ],
   +      'revision_log' => $this->randomString()
   
   @@ -156,18 +156,18 @@ public function testComment() {
   +        'format' => $this->randomMachineName()
   +      ]]
   
   +++ b/core/modules/system/src/Tests/Entity/EntityCrudHookTest.php
   @@ -158,8 +158,8 @@ public function testCommentHooks() {
   +      'changed' => REQUEST_TIME
   
   @@ -303,8 +303,8 @@ public function testNodeHooks() {
   +      'changed' => REQUEST_TIME
   
   +++ b/core/modules/system/src/Tests/Entity/EntityFieldTest.php
   @@ -674,11 +674,11 @@ public function testEntityConstraintValidation() {
   +      'title' => $this->randomString()
   
   @@ -695,11 +695,11 @@ public function testEntityConstraintValidation() {
   +      'title' => $this->randomString()
   
   +++ b/core/modules/system/src/Tests/Entity/EntityReferenceSelection/EntityReferenceSelectionAccessTest.php
   @@ -84,35 +84,38 @@ public function testNodeHandler() {
   +      'uid' => 1
   ...
   +      'uid' => 1
   ...
   +      'uid' => 1
   
   @@ -350,27 +353,25 @@ public function testCommentHandler() {
   +      'uid' => 1
   ...
   +      'uid' => 1
   
   +++ b/core/modules/taxonomy/src/Tests/TermTranslationFieldViewTest.php
   @@ -74,16 +74,16 @@ public function testTranslatedTaxonomyTermReferenceDisplay() {
   +        'format' => 'basic_html'
   ...
   +      'langcode' => $this->baseLangcode
   

   For multiline arrays, we always leave a trailing comma. That way future patches will affect fewer lines.

2. +++ b/core/modules/system/src/Tests/Entity/EntityReferenceSelection/EntityReferenceSelectionAccessTest.php
   @@ -84,35 +84,38 @@ public function testNodeHandler() {
   -    foreach ($node_values as $key => $values) {
   -      $node = entity_create('node', $values);
   -      $node->save();
   -      $nodes[$key] = $node;
   -      $node_labels[$key] = Html::escape($node->label());
   -    }
   
   @@ -350,27 +353,25 @@ public function testCommentHandler() {
   -    foreach ($node_values as $key => $values) {
   -      $node = entity_create('node', $values);
   -      $node->save();
   -      $nodes[$key] = $node;
   -    }
   

   Why are these loops being removed? It seems like the test would expect those nodes.

3. +++ b/core/modules/system/src/Tests/Entity/EntityReferenceSelection/EntityReferenceSelectionAccessTest.php
   @@ -84,35 +84,38 @@ public function testNodeHandler() {
   +    ¶
   
   @@ -350,27 +353,25 @@ public function testCommentHandler() {
   +    ¶
   

   Unnecessary whitespace.

#12.2 - the test passes locally, so that shouldn't be a problem. I fixed the comma issues and it looked like a couple of use Drupal\node\Entity\Node; were missing.

Looks like I was behind on 8.1.x, rebased patch.

More imports of code.

+++ b/core/modules/system/src/Tests/Entity/EntityReferenceSelection/EntityReferenceSelectionAccessTest.php
@@ -84,35 +85,38 @@ public function testNodeHandler() {
-    foreach ($node_values as $key => $values) {

@@ -350,27 +354,25 @@ public function testCommentHandler() {
-    foreach ($node_values as $key => $values) {

Well, again, the scope here is only to remove the usages of entity_create(), not unwrap loops.

Please revert these changes so they leave the loops in.

Thanks.

ok.

Patch in #19 applies. My IDE says no more occurrences of entity_create('node') exist. The patch only changes entity_create('node') to Node::create.

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!