Problem/Motivation

   * @param string $cache_key
   *   Cache key prefix to use, the language code will be appended
   *   automatically.

I can't find anything that would append the language code. I can find, however, three plugin managers doing

$this->setCacheBackend($cache_backend, 'contextual_links_plugins:' . $language_manager->getCurrentLanguage()->getId(), array('contextual_links_plugins'));
$this->setCacheBackend($cache_backend, 'local_action_plugins:' . $language_manager->getCurrentLanguage()->getId(), array('local_action'));
$this->setCacheBackend($cache, 'local_task_plugins:' . $language_manager->getCurrentLanguage()->getId(), array('local_task'));

so either these three are wrong or the doxygen is wrong.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2668752-3.patch1.06 KBmr.baileys
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx created an issue. See original summary.

tim.plunkett’s picture

#2281905: Stop caching plugin discovery/info hooks by language changed this, looks like the doxygen was left unchanged

mr.baileys’s picture

Status: Active » Needs review
FileSize
1.06 KB
chx’s picture

Thanks for the patch! I haven't rolled one because I am unsure: what do we say about what those three are doing? If anyone else stumbled on them like I did , why? Do we leave a comment on them? Do we leave a comment here ? Just leave it alone?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Berdir’s picture

Title: DefaultPluginManager::setCacheBackend doxygen is wrong » DefaultPluginManager::setCacheBackend has wrong information about language suffix
Status: Needs review » Reviewed & tested by the community

I think just removing the wrong information is enough.

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Works for me. Thanks @Berdir! Committed to 8.4.x and cherry-picked to 8.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.